[ML] Fixing "aggs" use in datafeeds #56002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
added
bug
jgowdyelastic
requested review from
walterra,
darnautov,
alvarezmelissa87 and
peteharverson
|
Pinging @elastic/ml-ui (:ml) |
darnautov
approved these changes
Jan 27, 2020
x-pack/legacy/plugins/ml/public/application/jobs/new_job/common/job_creator/configs/datafeed.ts
Outdated
Show resolved
Hide resolved
💚 Build SucceededTo update your PR or re-run it, just comment with: |
jgowdyelastic
deleted the
fixing-aggs-rather-than-aggregations-use-in-datafeeds
branch
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Jan 27, 2020
* [ML] Fixing "aggs" use in datafeeds * removing use of Record
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Jan 27, 2020
* [ML] Fixing "aggs" use in datafeeds * removing use of Record
jgowdyelastic
added a commit
that referenced
this pull request
Jan 27, 2020
jgowdyelastic
added a commit
that referenced
this pull request
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing bug when loading aggregations from the datafeed config. If the shortened
aggskey is used, the fields would not be found.Relates to #55180 and so doesn't require its own release notes.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately