Exclude tutorials from code ownership #55705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
added
chore
release_note:skip
ChrsMark
reviewed
Jan 23, 2020
Member
ChrsMark
left a comment
ChrsMark
left a comment
There was a problem hiding this comment.
We also push to src/legacy/core_plugins/kibana/public/home/tutorial_resources/logos for the logos. Should this folder be included too?
ChrsMark
approved these changes
Jan 23, 2020
Member
ChrsMark
left a comment
ChrsMark
left a comment
There was a problem hiding this comment.
I see this was already included! lgmt, thanks!
Contributor
Author
|
You are right @ChrsMark, those also have to be migrated. I will move them separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR excludes the tutorials folder in the home plugin for now because the tutorials itself are not owned by Kibana app and most will move out soon.
Once the bulk of these changes is done, this rule can be simplified again.
[skip ci]