[Bug][Filters] Incorrect result, when calling setFilters() with multiple duplicates between app and global filters

[Dosant]

Summary

Working on #55158, noticed bugs while calling setFilters()

Calling setFilters() with multiple similar global and app filters doesn't work as it was intended according to code.
The root cause was appFilters.splice(i, 1); which mutated original array, so the loop _.each loop could miss remaining app filters.

I am not sure exactly if this bug in the method is causing any end user bugs in current master, but with #55158 it prevents back button history to work correctly with pinning / unpinning multiple filters

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

• This was checked for cross-browser compatibility, including a check against IE11
• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• This was checked for keyboard-only and screenreader accessibility

For maintainers

• This was checked for breaking API changes and was labeled appropriately
• This includes a feature addition or change that requires a release note and was labeled appropriately

[elasticmachine]

Pinging @elastic/kibana-app-arch (Team:AppArch)

[Dosant]

@elasticmachine merge upstream

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 040147f

History

• 💚 Build #21941 succeeded 4ad51c3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[lizozom]

LGTM