Skip to content

Move test utils inside the input_control_vis #55169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 22, 2020
Merged

Move test utils inside the input_control_vis #55169

merged 5 commits into from
Jan 22, 2020

Conversation

@sulemanof
Copy link
Contributor

@sulemanof sulemanof commented Jan 17, 2020

Summary

This is a part of #54339.
Move test helpers to an appropriate name folder

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@sulemanof sulemanof requested a review from flash1293 January 17, 2020 12:33
@sulemanof sulemanof added release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0 labels Jan 17, 2020
@sulemanof
Copy link
Contributor Author

sulemanof commented Jan 21, 2020

@elasticmachine merge upstream

flash1293
flash1293 approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once green

@kibanamachine
Copy link
Contributor

kibanamachine commented Jan 21, 2020

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sulemanof sulemanof merged commit ed04b17 into elastic:master Jan 22, 2020
@sulemanof sulemanof deleted the tests/input_control branch January 22, 2020 09:41
sulemanof added a commit to sulemanof/kibana that referenced this pull request Jan 22, 2020
@sulemanof @elasticmachine
Move test utils inside the input_control_vis (elastic#55169)
c757ec9 
* Move test utils to an appropriate folder

* Change imports

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@sulemanof sulemanof mentioned this pull request Jan 22, 2020
Merged
sulemanof added a commit that referenced this pull request Jan 22, 2020
@sulemanof @elasticmachine
Move test utils inside the input_control_vis (#55169) (#55526)
88b15ff 
* Move test utils to an appropriate folder

* Change imports

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flash1293 flash1293 flash1293 approved these changes

Assignees

No one assigned

Labels

backported release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sulemanof @kibanamachine @flash1293 @elasticmachine