Es client cleanup #54337
Merged
Es client cleanup #54337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizozom
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
Contributor
Author
|
@elasticmachine merge upstream |
1 similar comment
Contributor
Author
|
@elasticmachine merge upstream |
added 11 commits
January 21, 2020 19:03
lizozom
force-pushed
the
newplatform/data/es-client-cleanup
branch
from
e71c889 to
b75e15c
Compare
added 2 commits
January 21, 2020 20:53
kindsun
reviewed
Jan 21, 2020
Contributor
Author
|
@elasticmachine merge upstream |
…om:lizozom/kibana into newplatform/data/es-client-cleanup
Contributor
Author
|
@elasticmachine merge upstream |
…es-client-cleanup
…om/kibana into newplatform/data/es-client-cleanup
Contributor
Author
|
@elasticmachine merge upstream |
flash1293
approved these changes
Jan 23, 2020
Contributor
flash1293
left a comment
flash1293
left a comment
There was a problem hiding this comment.
Kibana app changes LGTM, didn't test locally. One piece of angular less 🎉
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
ignoring request to update branch, pull request is closed |
Contributor
Author
|
@elasticmachine merge upstream |
…es-client-cleanup
…om/kibana into newplatform/data/es-client-cleanup
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
lizozom
pushed a commit
to lizozom/kibana
that referenced
this pull request
Jan 26, 2020
* Add esClient instance to data.__LEGACY and replace old usages * add es clinet to setup karma mock * delete unneeded import * fix get inner angular * Fix karma test * Fix vega browser test * Update esClient usage * ts fixes * ts + karma tests * update tests * Fix karma test * eslint * Register default strategy from plugin * export * Revert map change * Delete legacy saved objects client provider * Fix management digest cycle Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
lizozom
pushed a commit
that referenced
this pull request
Jan 26, 2020
* Add esClient instance to data.__LEGACY and replace old usages * add es clinet to setup karma mock * delete unneeded import * fix get inner angular * Fix karma test * Fix vega browser test * Update esClient usage * ts fixes * ts + karma tests * update tests * Fix karma test * eslint * Register default strategy from plugin * export * Revert map change * Delete legacy saved objects client provider * Fix management digest cycle Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Depends on merging #53766
Replace any occurecnces of
$injector.get('es')with the instance ofEsClientexposed bynewPlatform.start.data.search.__LEGACYChecklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers