Cleanup code / reenable eslint overwrite for src/legacy/core_plugins/kibana
#54222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kertal
added
:KibanaApp/fix-it-week
v7.6.0
v8.0.0
Team:Visualizations
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
…-07-remove-src-legacy-core-plugins-kibana-eslint-overwrite
…-07-remove-src-legacy-core-plugins-kibana-eslint-overwrite
myasonik
approved these changes
Jan 8, 2020
Contributor
myasonik
left a comment
myasonik
left a comment
There was a problem hiding this comment.
Seems like a small failure - good to ship once build is green
| id: selectedIndexPattern.id, | ||
| title: selectedIndexPattern.attributes!.title, | ||
| id: selectedId, | ||
| title: attributes ? attributes.title : '', |
Contributor
There was a problem hiding this comment.
Just some code golf: ⛳️
Suggested change
| title: attributes ? attributes.title : '', | |
| title: attributes?.title || '', |
Member
Author
There was a problem hiding this comment.
Hole in one! 🏌 ! Many thx for the comment + review!
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Jan 9, 2020
…4222) * Cleanup code * Remove eslint overwrite
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 9, 2020
* master: Remove eslint overwrite for src/legacy/core_plugins/kibana (elastic#54222)
kertal
added a commit
that referenced
this pull request
Jan 9, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 13, 2020
* master: Remove eslint overwrite for src/legacy/core_plugins/kibana (elastic#54222)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix eslint complains and re-enable eslint rules for
src/legacy/core_plugins/kibanaFixes #49547
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately