Skip to content

Conversation

@legrego
Copy link
Member

@legrego legrego commented Jan 7, 2020

Summary

Adds terms query to delete and copy-to-space api suites to only assert on the expected saved object types.

Resolves #54121
Resolves #54099
Resolves #54106
Resolves #31864
Resolves #54084

@legrego
Copy link
Member Author

legrego commented Jan 7, 2020

Testing flakeyness resolved by running xpack-ciGroup-8 42 times: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/125/

@legrego legrego marked this pull request as ready for review January 7, 2020 19:00
@legrego legrego added v7.5.2 v7.6.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// labels Jan 7, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@legrego legrego requested a review from a team January 7, 2020 19:03
@legrego
Copy link
Member Author

legrego commented Jan 7, 2020

No test failures after running the suite 42 times. Merging!

@legrego legrego merged commit 03ec7af into elastic:master Jan 7, 2020
@legrego legrego deleted the spaces/fix-flakey-api-tests branch January 7, 2020 19:50
legrego added a commit to legrego/kibana that referenced this pull request Jan 7, 2020
* adding terms query

* run x-pack-ciGroup8 44 times

* Revert "run x-pack-ciGroup8 44 times"

This reverts commit 7d10217.
legrego added a commit that referenced this pull request Jan 7, 2020
* adding terms query

* run x-pack-ciGroup8 44 times

* Revert "run x-pack-ciGroup8 44 times"

This reverts commit 7d10217.
legrego added a commit that referenced this pull request Jan 7, 2020
* adding terms query

* run x-pack-ciGroup8 44 times

* Revert "run x-pack-ciGroup8 44 times"

This reverts commit 7d10217.
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 8, 2020
* master: (55 commits)
  [ui/public/utils] Copy rarely used items to where they are consumed (elastic#53819)
  set AppArch team as an owner of the search endpoints (elastic#54131)
  Don't expose Elasticsearch client as Observable (elastic#53824)
  [SIEM] Cleanup unnecessary use of enzyme-to-json (elastic#53980)
  fix ui exports doc (elastic#54138)
  change markdown element title (elastic#54194)
  [Logs UI] Refactor log position to hooks (elastic#53540)
  [SIEM] Implement NP Plugin Setup (elastic#54030)
  [DOCS] Updates ML links (elastic#53613)
  sort renovate packages in config
  Spaces - fix flakey api tests (elastic#54154)
  Remove dependency that was causing effect to re-execute infinitely. (elastic#54160)
  [dev/run] expose unexpected flags as more than just names (elastic#54080)
  [DOCS] Moves index pattern doc to Discover (elastic#53347)
  [SIEM] Cleanup React imports (elastic#53981)
  Update eslint related packages (elastic#54107)
  [Uptime] Added date range filter into expanded list query (elastic#52609)
  [SIEM] Add react/display-name eslint rule (elastic#53107)
  [SIEM] Enable eslint prefer-template rule (elastic#53983)
  Elasticsearch snapshots automation (elastic#53706)
  ...
@kibanamachine
Copy link
Contributor

💔 Build Failed

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment