[Maps] gather field formatters in data request #53311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nc in vector_style
nreese
added
chore
Team:Geo
Contributor
|
Pinging @elastic/kibana-gis (Team:Geo) |
Contributor
thomasneirynck
left a comment
thomasneirynck
left a comment
There was a problem hiding this comment.
Thanks! Some suggestions in the comments.
x-pack/legacy/plugins/maps/public/layers/styles/vector/vector_style.js
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/maps/public/layers/styles/vector/vector_style.js
Outdated
Show resolved
Hide resolved
thomasneirynck
approved these changes
Dec 17, 2019
Contributor
thomasneirynck
left a comment
thomasneirynck
left a comment
There was a problem hiding this comment.
+1, but using lambda-notation add noise imho, consider removing
x-pack/legacy/plugins/maps/public/layers/styles/vector/vector_style.js
Outdated
Show resolved
Hide resolved
| return fieldMeta ? fieldMeta : fieldMetaFromLocalFeatures; | ||
| }; | ||
|
|
||
| _getFieldFormatter = fieldName => { |
Contributor
There was a problem hiding this comment.
Similar imho. make this part of the type _getFieldFormatter(fieldName){
Contributor
Author
|
retest |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Dec 18, 2019
* [Maps] gather field formatters in data request so they can be used sync in vector_style * review feedback * hasMatchingMetricField * review feedback * fix typo in function name
nreese
added a commit
that referenced
this pull request
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses data request to gather field formatters so they can be accessed synchronously during data preparation phase. This will be required with text labels since setFeatureState must stay synchronous and field formatters are now needed in that method.
decouples #52957 and #53173