Use savedObjects provided by the platform instead of legacy shim.
#53264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azasypkin
added
chore
Team:Security
Contributor
|
Pinging @elastic/kibana-security (Team:Security) |
legrego
reviewed
Dec 17, 2019
| export class Plugin { | ||
| private readonly logger: Logger; | ||
| private savedObjectsSetup?: ReturnType<typeof setupSavedObjects>; | ||
| private savedObjectsSetup!: ReturnType<typeof setupSavedObjects>; |
Member
There was a problem hiding this comment.
question Is there a benefit or preference to using ReturnType<typeof setupSavedObjects> instead of the exported SavedObjectsSetup type?
Member
Author
There was a problem hiding this comment.
Hmm, looks like ReturnType<typeof setupSavedObjects> is just a stupid alternative for SavedObjectsSetup, have no idea why I have it here 🙈 Good catch, will fix!
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Member
Author
|
7.x/7.6.0: 05ca2db |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
savedObjectsprovided by the platform instead of legacy shim in Encrypted Saved Objects plugin.