value suggestions server route -> data plugin #53191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexwizp
added
v7.6.0
v8.0.0
release_note:skip
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
lizozom
approved these changes
Dec 17, 2019
Contributor
lizozom
left a comment
lizozom
left a comment
There was a problem hiding this comment.
Tested and LGTM
Left a couple of comments
| import { IFieldType } from './fields'; | ||
|
|
||
| export interface IIndexPattern { | ||
| [key: string]: any; |
Contributor
Author
There was a problem hiding this comment.
@lizozom
Copied from /data/public/index_patterns/index_patterns/index_pattern.ts
I need it cause for server code we get fields from IndexPattern.attributes. It's valid only for server code but I didn't wanted to introduce new types for server/index_patterns
If it's critical I can refactor this part
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Dec 18, 2019
* value suggestions server route -> data plugin Closes elastic#52842 * fix PR comments * fix PR comments
alexwizp
added a commit
that referenced
this pull request
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #52842
Summary
The suggestionsProvider has already been moved to the new platform data plugin in src/plugins/data/public/suggestions_provider. There is also an api route that it depends on, which should be relocated as well:
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers