[SIEM] Fix doubled drag handles in Timeline #52679

patrykkopycinski · 2019-12-10T20:07:40Z

Summary

Fixes doubled drag handle
Cleans up logic of plain_column_renderer

Fixes #48813

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

elasticmachine · 2019-12-10T20:27:52Z

Pinging @elastic/siem (Team:SIEM)

elasticmachine · 2019-12-10T21:51:34Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: ebd55ba

History

💔 Build #14635 failed e873ea7

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…multiple-draggables # Conflicts: # x-pack/legacy/plugins/siem/public/components/drag_and_drop/draggable_wrapper.tsx # x-pack/legacy/plugins/siem/public/components/event_details/event_fields_browser.tsx # x-pack/legacy/plugins/siem/public/components/timeline/body/renderers/formatted_field.test.tsx

patrykkopycinski · 2020-01-06T16:44:33Z

@elasticmachine merge upstream

andrew-goldstein · 2020-01-06T18:06:54Z

x-pack/legacy/plugins/siem/public/components/skeleton_row/index.tsx

+          (_, i) => <Cell cellColor={cellColor} cellMargin={cellMargin} key={i} />,
+          [cellCount]
+        ),
+      [cellCount]


consider listing cellColor and cellMargin as dependencies

andrew-goldstein · 2020-01-07T01:25:21Z

x-pack/legacy/plugins/siem/public/components/event_details/event_fields_browser.tsx

+          ...fieldsByName[item.field],
+          valuesConcatenated: item.values != null ? item.values.join() : '',
+        })),
+      []


consider listing data and fieldsByName as dependencies

andrew-goldstein · 2020-01-07T01:47:20Z

x-pack/legacy/plugins/siem/public/components/timeline/body/renderers/formatted_field.tsx

-            </EuiToolTip>
-          </TruncatableText>
-        ) : (
+  } else if (columnNamesNotDraggable.includes(fieldName)) {


andrew-goldstein

Thanks @patrykkopycinski for this fix and cleanup! 🙏

Verified locally that this fixes the double drag handles in:
✅ timeline / event viewer columns
✅ expanded events

Please consider declaring the additional dependencies to useMemo per the comments below. Everything else is LGTM! 🚀 🙏

…multiple-draggables

kibanamachine · 2020-01-07T13:31:53Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 048aaaf

History

💔 Build #18346 failed 9f8a7a7
💔 Build #18141 failed 967c765
💔 Build #18129 failed c183f3c
💔 Build #17939 failed bae5505
💔 Build #14645 failed ebd55ba

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…le-saved-objects * 'master' of github.com:elastic/kibana: (86 commits) [Uptime] Added date range filter into expanded list query (elastic#52609) [SIEM] Add react/display-name eslint rule (elastic#53107) [SIEM] Enable eslint prefer-template rule (elastic#53983) Elasticsearch snapshots automation (elastic#53706) [SIEM] Enable eslint react/no-children-prop (elastic#53985) [DOCS][Reporting] Adds info about using a custom reporting index (elastic#54052) Changing background color to align with EUI color (elastic#54060) Fix linting issues (elastic#54068) NP Migration: Move doc views registry and existing doc views into discover plugin (elastic#53465) [ML] DF Analytics job creation: Add 'excludes' input field to form (elastic#53856) EMT-issue-65: add endpoint list api (elastic#53861) [SIEM] Fix doubled drag handles in Timeline (elastic#52679) Functional tests: refactor visualize_page (elastic#53845) [Dashboard] Redesign empty screen in readonly mode (elastic#54073) [ML] Support search for partitions on Single Metric Viewer (elastic#53879) update apm index pattern (elastic#54095) Add data ui for envoyproxy Metricbeat Module (elastic#53476) [ML] persist the brush when expanded to full width (elastic#54020) Skip failing test (elastic#54100) [APM] Show errors on the timeline instead of under the transaction (elastic#53756) ... # Conflicts: # src/legacy/core_plugins/console/public/np_ready/application/contexts/services_context.tsx # src/legacy/core_plugins/console/public/np_ready/application/index.tsx

…/kibana into feature/console-saved-objects * 'feature/console-saved-objects' of github.com:jloleysens/kibana: (86 commits) [Uptime] Added date range filter into expanded list query (elastic#52609) [SIEM] Add react/display-name eslint rule (elastic#53107) [SIEM] Enable eslint prefer-template rule (elastic#53983) Elasticsearch snapshots automation (elastic#53706) [SIEM] Enable eslint react/no-children-prop (elastic#53985) [DOCS][Reporting] Adds info about using a custom reporting index (elastic#54052) Changing background color to align with EUI color (elastic#54060) Fix linting issues (elastic#54068) NP Migration: Move doc views registry and existing doc views into discover plugin (elastic#53465) [ML] DF Analytics job creation: Add 'excludes' input field to form (elastic#53856) EMT-issue-65: add endpoint list api (elastic#53861) [SIEM] Fix doubled drag handles in Timeline (elastic#52679) Functional tests: refactor visualize_page (elastic#53845) [Dashboard] Redesign empty screen in readonly mode (elastic#54073) [ML] Support search for partitions on Single Metric Viewer (elastic#53879) update apm index pattern (elastic#54095) Add data ui for envoyproxy Metricbeat Module (elastic#53476) [ML] persist the brush when expanded to full width (elastic#54020) Skip failing test (elastic#54100) [APM] Show errors on the timeline instead of under the transaction (elastic#53756) ...

[SIEM] Fix doubled drag handles in Timeline

e873ea7

patrykkopycinski self-assigned this Dec 10, 2019

patrykkopycinski added the Team:SIEM label Dec 10, 2019

patrykkopycinski added release_note:skip Skip the PR/issue when compiling release notes v7.6.0 v8.0.0 labels Dec 10, 2019

patrykkopycinski requested review from XavierM, andrew-goldstein and spong December 10, 2019 20:28

Update snapshots

ebd55ba

patrykkopycinski requested review from FrankHassanabad, afgomez, angorayc, rylnd and stephmilovic and removed request for afgomez January 4, 2020 16:08

elasticmachine and others added 2 commits January 6, 2020 08:44

Merge branch 'master' into fix/timeline-multiple-draggables

c183f3c

fix types

967c765

andrew-goldstein reviewed Jan 6, 2020

View reviewed changes

andrew-goldstein reviewed Jan 7, 2020

View reviewed changes

andrew-goldstein approved these changes Jan 7, 2020

View reviewed changes

patrykkopycinski added 3 commits January 7, 2020 10:04

Merge branch 'master' of github.com:elastic/kibana into fix/timeline-…

474549b

…multiple-draggables

WIP

9f8a7a7

fix logic

048aaaf

patrykkopycinski merged commit f46e8e2 into elastic:master Jan 7, 2020

patrykkopycinski deleted the fix/timeline-multiple-draggables branch January 7, 2020 14:56

patrykkopycinski mentioned this pull request Jan 7, 2020

[7.x] [SIEM] Fix doubled drag handles in Timeline (#52679) #54130

Merged

patrykkopycinski added a commit that referenced this pull request Jan 7, 2020

[SIEM] Fix doubled drag handles in Timeline (#52679) (#54130)

28ebfd0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SIEM] Fix doubled drag handles in Timeline #52679

[SIEM] Fix doubled drag handles in Timeline #52679

Uh oh!

patrykkopycinski commented Dec 10, 2019 •

edited

Loading

Uh oh!

elasticmachine commented Dec 10, 2019

Uh oh!

elasticmachine commented Dec 10, 2019

Uh oh!

patrykkopycinski commented Jan 6, 2020

Uh oh!

andrew-goldstein Jan 6, 2020

Uh oh!

andrew-goldstein Jan 7, 2020

Uh oh!

andrew-goldstein Jan 7, 2020

Uh oh!

andrew-goldstein left a comment

Uh oh!

kibanamachine commented Jan 7, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[SIEM] Fix doubled drag handles in Timeline #52679

[SIEM] Fix doubled drag handles in Timeline #52679

Uh oh!

Conversation

patrykkopycinski commented Dec 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Dec 10, 2019

Uh oh!

elasticmachine commented Dec 10, 2019

💔 Build Failed

History

Uh oh!

patrykkopycinski commented Jan 6, 2020

Uh oh!

andrew-goldstein Jan 6, 2020

Choose a reason for hiding this comment

Uh oh!

andrew-goldstein Jan 7, 2020

Choose a reason for hiding this comment

Uh oh!

andrew-goldstein Jan 7, 2020

Choose a reason for hiding this comment

Uh oh!

andrew-goldstein left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Jan 7, 2020

💚 Build Succeeded

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

patrykkopycinski commented Dec 10, 2019 •

edited

Loading