Update dependency @elastic/charts to v16

[markov00]

Summary

This PR contains the following updates:

Package	Type	Update	Change
@elastic/charts	dependencies	major	^14.0.0 -> ^16.0.1

---

Release Notes

elastic/elastic-charts

16.0.1 (2020-01-03)

Bug Fixes

• specs: shows a chart message without series specified (#506) (ba1a67b)

16.0.0 (2020-01-02)

Bug Fixes

• external pointer: avoid recursive-loops on pointer events (#503) (c170f0d), closes #504

BREAKING CHANGES

• external pointer: The onCursorUpdate Settings property is changed to a more generic
  onPointerUpdate. The same apply for the event type CursorEvent that is now PointerEvent and can assume a PointerOverEvent or PointOutEvent shape (see TS types)

15.0.5 (2019-12-12)

Bug Fixes

• render stacked bar with stringified values (#488) (811ee90), closes #487

15.0.4 (2019-12-12)

Bug Fixes

• highlighter: clip path unique id (#490) (dc93624), closes #489

15.0.3 (2019-12-05)

Bug Fixes

• highlighter: hide it when tooltip type is None (#482) (6032c29), closes #478 #479

15.0.2 (2019-12-05)

Bug Fixes

• crosshair: hide horizontal line when the pointer is outside chart (#484) (654d929), closes #483

15.0.1 (2019-12-02)

Bug Fixes

• redux dev tools config (#465) (89d5364)

15.0.0 (2019-12-02)

Code Refactoring

• series identifications throughout library (#419) (66a48ff)
• use redux in favour of mobx (#281) (cd34716)

BREAKING CHANGES

• GeometryId is now SeriesIdentifier. customSeriesColors prop on SeriesSpec which used to take a CustomSeriesColorsMap, now expects a CustomSeriesColors type. LegendItemListener now passes the SeriesIdentifier type as the first callback argument.
• SpecId,AxisId, AnnotationId types are down-casted to a string type. The getSpecId, getAxisId and getAnnotationId methods still exist and but return just the same passed string until deprecated in a future version. The spec ids, previously id, axisId,annotationId etc are now aligned to use the same prop name: id. The chart rendering status data-ech-render-complete and data-ech-render-count is no more at the root level of the echChart div, but on its child element: echChartStatus. The Spec has two new private properties called chartType and specType.

Compare Source

PR Notes:

The PR fix the hover issues discovered by @peteharverson in the ML charts.

Missing discussion points

#50513 (comment)

from: @nickofthyme to: @spalger

I wanted to verify with you. I kept getting the following error when react hooks since we are currently using react as a dependency not a peerDependency in @elastic/charts. Hopefully, this is changed soon 👉elastic/elastic-charts#378

Uncaught Invariant Violation: Invalid hook call. Hooks can only be called inside of the body of a function component. This could happen for one of the following reasons:
1. You might have mismatching versions of React and the renderer (such as React DOM)
2. You might be breaking the Rules of Hooks
3. You might have more than one copy of React in the same app

I was able to fix it by adding react to the yarn resolutions to force the version to match/use that of kibana but wanted to make sure this doesn't have any negative consequences that I'm not aware of, so long as all checks pass.

---

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

• This was checked for cross-browser compatibility, including a check against IE11
• [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• [ ] Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• [ ] This was checked for keyboard-only and screenreader accessibility

For maintainers

• This was checked for breaking API changes and was labeled appropriately
• This includes a feature addition or change that requires a release note and was labeled appropriately

[simianhacker]

Is this a duplicate of #52621

[markov00]

hey @jbudz @simianhacker could you please re-approve/review this PR? I've closed the Renovate one because someone (the Renovate bot, us or someone else) rebased the renovate bot PR removing our changes and to avoid losing again the changes I opened this one. Thanks and sorry for the noise.

[simianhacker]

As I was testing I ran into this error. To reproduce:

1. Go to Metrics Explorer
2. Add a metric, wait for page to update.
3. Delete the metric

I checked master and everything works as expected. Let me know if there is more we need to do on our end to prevent this.

[markov00]

As I was testing I ran into this error. To reproduce:

1. Go to Metrics Explorer
2. Add a metric, wait for page to update.
3. Delete the metric

I checked master and everything works as expected. Let me know if there is more we need to do on our end to prevent this.

@simianhacker I will add a missing check on your code. I will also update the library to fix that internally (the chart throw that error when you have a chart with no series in it

[markov00]

blocked by elastic/elastic-charts#503

[peteharverson]

Tested ML charts and all LGTM. Confirmed that the hover issue is fixed, so if tooltip type is set as None, the highlighter on bars and points is no longer displayed.

[markov00]

@elasticmachine merge upstream

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 0b516ec

History

• 💔 Build #17926 failed 80d11ab8a767b37100807162de1f0a1a7927c7bb
• 💚 Build #17906 succeeded 059597e
• 💚 Build #17729 succeeded fd21c8a
• 💚 Build #17610 succeeded 7e00f5b
• 💔 Build #17549 failed 210881b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream