Allow loggers to create child loggers via 'get' method #52605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgayvallet
added
Feature:New Platform
release_note:skip
pgayvallet
changed the title
get method to Logger
pgayvallet
added
the
Team:Core
|
Pinging @elastic/kibana-platform (Team:Platform) |
azasypkin
approved these changes
Dec 10, 2019
joshdover
approved these changes
Dec 13, 2019
| warn: jest.fn(), | ||
| get: jest.fn(), | ||
| }; | ||
| mockLog.get.mockImplementation((...ctx) => ({ |
There was a problem hiding this comment.
super nit: use context for consistency with logging service mock
There was a problem hiding this comment.
context is already declared in the upper scope (no-shadow) 😢
|
@elasticmachine merge upstream |
pgayvallet
force-pushed
the
kbn-39695-logger-factory
branch
from
bbfc591
to
3f2c557
Compare
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
pgayvallet
added a commit
to pgayvallet/kibana
that referenced
this pull request
Dec 16, 2019
* add 'Logger.get' method * updates generated doc * resolve merge conflicts
pgayvallet
added a commit
that referenced
this pull request
Dec 16, 2019
timductive
pushed a commit
to timductive/kibana
that referenced
this pull request
Dec 16, 2019
* add 'Logger.get' method * updates generated doc * resolve merge conflicts
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #39695
Avoid having to propagate both
LoggerandLoggerFactoryin nested parts of the code by adding agetmethod onLoggerthat will creates a child logger from it's context.PR also adds a
createLoggermethod to the logging service mock, and uses it in some plugin tests that were manually declaring a mockedLoggerChecklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately