Skip to content

[Uptime] Fixed failing unit test because of timestamp in snapshot #52302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 5, 2019
Merged

[Uptime] Fixed failing unit test because of timestamp in snapshot #52302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
23cf001
fixed test
shahzad31 Dec 5, 2019
f813cd3
update snaps
shahzad31 Dec 5, 2019
3a68893
Merge branch 'master' into fix/issue-with-timestamp-mock-in-test
shahzad31 Dec 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../monitor_list/monitor_list_drawer/__tests__/__snapshots__/most_recent_error.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion ...mponents/functional/monitor_list/monitor_list_drawer/__tests__/most_recent_error.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

import { shallowWithIntl, renderWithIntl } from 'test_utils/enzyme_helpers';
import React from 'react';
import moment from 'moment';
import { BrowserRouter as Router } from 'react-router-dom';
import { MostRecentError } from '../most_recent_error';
import { MonitorDetails, MonitorError } from '../../../../../../common/runtime_types';
Expand All @@ -14,6 +15,10 @@ describe('MostRecentError component', () => {
let monitorDetails: MonitorDetails;
let monitorError: MonitorError;

beforeAll(() => {
moment.prototype.fromNow = jest.fn(() => '5 days ago');
});

beforeEach(() => {
monitorError = {
type: 'io',
Expand All @@ -39,7 +44,7 @@ describe('MostRecentError component', () => {
expect(component).toMatchSnapshot();
});

it.skip('renders properly with empty data', () => {
it('renders properly with mock data', () => {
const component = renderWithIntl(
<Router>
<MostRecentError
Expand Down