Ability to add manual exceptions for the clean dll logic during the build #51642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistic
added
chore
Team:Operations
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
spalger
reviewed
Nov 25, 2019
Contributor
💚 Build Succeeded |
spalger
approved these changes
Nov 25, 2019
This was referenced Nov 25, 2019
mistic
added a commit
to mistic/kibana
that referenced
this pull request
Nov 26, 2019
Member
Author
|
7.x/7.6.0: 318dd67 |
mistic
added a commit
that referenced
this pull request
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That should solve the problem on #48449
In that PR we found out that it is possible to have an use case where we would have a node_module bundle inside the DLL, with some files not bundled inside of it, still need inside the bundles directory. As we were cleaning those kind of situations before, we need a way to avoid cleaning such a files when needed.
For now I think that strategy is enough.