Deprecate xpack.telemetry.* instead of removing it #51117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While telemetry plugin has moved and its configurations no longer have the xpack prefix, for the time being we should only warn when we encounter the existing config names rather than blocking startup entirely.
epixa
added
Feature:Telemetry
v8.0.0
release_note:skip
|
Pinging @elastic/kibana-stack-services (Team:Stack Services) |
|
LGTM: I tested the original bug and saw the fix in effect |
|
@Bamieh Let me know tomorrow if you have concerns or know of problems with this approach, but in the meantime I'm going to proceed with merging this if we get CI green. |
|
LGTM. Tested the deprecated setting xpack.telemetry.enabled and then removed it and tested the new setting telemetry.enabled. cc @LeeDr |
💚 Build Succeeded |
epixa
added a commit
to epixa/kibana
that referenced
this pull request
Nov 19, 2019
While telemetry plugin has moved and its configurations no longer have the xpack prefix, for the time being we should only warn when we encounter the existing config names rather than blocking startup entirely.
This was referenced Nov 19, 2019
epixa
added a commit
to epixa/kibana
that referenced
this pull request
Nov 19, 2019
While telemetry plugin has moved and its configurations no longer have the xpack prefix, for the time being we should only warn when we encounter the existing config names rather than blocking startup entirely.
epixa
added a commit
that referenced
this pull request
Nov 20, 2019
epixa
added a commit
that referenced
this pull request
Nov 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While telemetry plugin has moved and its configurations no longer have
the xpack prefix, for the time being we should only warn when we
encounter the existing config names rather than blocking startup
entirely.
Fixes #51064