[ML] Enabling lat_long detector function in advanced wizard #50787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
added
release_note:enhancement
review
enhancement
jgowdyelastic
requested review from
alvarezmelissa87,
darnautov,
peteharverson and
walterra
Contributor
|
Pinging @elastic/ml-ui (:ml) |
Member
Author
|
cc @benwtrent |
peteharverson
approved these changes
Nov 15, 2019
Contributor
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
LGTM, although it highlights issues with the formatting of actual / typical values, and the empty actions menu, in the anomalies table for lat_long detectors. We should address this in a follow-up.
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
Member
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded |
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Nov 18, 2019
…50787) * [ML] Enabling lat_long agg in advanced wizard * fixing tests
jgowdyelastic
added a commit
that referenced
this pull request
Nov 18, 2019
2 tasks
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Dec 4, 2019
…50787) * [ML] Enabling lat_long agg in advanced wizard * fixing tests
jgowdyelastic
added a commit
that referenced
this pull request
Dec 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling the
lat_longdetector function in the advanced wizard for fields of typegeo_pointandgeo_shapeFixes #50502
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately