Remove experimental code app #49404

epixa · 2019-10-25T20:40:57Z

Summary

We've been experimenting with the code app for awhile now, but it just isn't fitting together the way we want it to, so we've decided not to pursue a code integration right now. To that end, we're removing the code plugin from future releases.

Since the code app was disabled by default, this shouldn't have an impact on most Kibana deployments. For those that explicitly enabled code, the app will no longer be available and a deprecation warning will be shown on startup due to lingering xpack.code.* configurations in kibana.yml. The plan will be (though it won't be implemented in this PR) that from 8.0 onward, any remainingxpack.code.* configurations in kibana.yml will be treated as unknown configurations and will fail Kibana startup.

Due to the amount of source code being removed, this pull request is too large to review in one go. Instead, it is best to review the individual commits, which break down like so:

The apm plugin was accidentally importing a function from the code plugin rather than the duplicate function that already existed in their own plugin, so that import statement is corrected under advisement from @sqren
The code plugin documentation is removed entirely. A separate PR will add a deprecation notice to docs for already-shipped versions.
Despite still existing on the file system, the legacy code is no longer imported into the xpack module and thus is not executed when Kibana starts up.
All code plugin functional tests are removed.
The legacy plugin is deleted, and the NP plugin shell is replaced with config deprecation. You can scroll down to see this particular part of the change or go directly to the remaining plugin files: plugin.ts and plugin.test.ts
Remove xpack.code translations

elasticmachine · 2019-10-25T20:42:49Z

Pinging @elastic/code (Team:Code)

tylersmalley · 2019-10-25T21:04:01Z

Just to confirm since the variables files appear to be different. Do we want to copy the code one over to APM since that is what they were using?

epixa · 2019-10-25T21:20:39Z

@tylersmalley that's a question for @sqren really. He told me to just use the one from the apm plugin, and I don't really know the implications.

epixa · 2019-10-25T21:22:56Z

Actually, the implementations of px appear to be identical, so I think this is fine:

apm: https://github.com/elastic/kibana/blob/master/x-pack/legacy/plugins/apm/public/style/variables.ts#L22-L24
code: https://github.com/elastic/kibana/blob/master/x-pack/legacy/plugins/code/public/style/variables.ts#L9-L11

epixa · 2019-10-26T00:41:41Z

I'm pretty sure the previous CI failure was a jenkins issue during shutdown after the CI jobs were green, but just in case I merged master to kick off another build.

elasticmachine · 2019-10-26T08:12:54Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 6508027

spalger

LGTM

snide

Checked to make sure the scss stuff is local to code. OKed from design.

elasticmachine · 2019-10-28T12:54:51Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 9c335ff

* Fix erroneous code plugin import in apm * Stop running legacy code plugin * Stop testing code app and apis * Remove code plugin source and deprecate config * Remove code plugin docs * Remove xpack.code translations * Remove code import on api_integration * Remove code privilege from security test * remove two more mentions of code * remove code es_archives * remove code doc images

epixa · 2019-10-28T19:49:59Z

FYI: Due to the exceptional nature of this change, we agreed to do it in 7.5.0 as well despite it being after FF. If push came to shove, we can delay that release. /cc @clintongormley

* Fix erroneous code plugin import in apm * Stop running legacy code plugin * Stop testing code app and apis * Remove code plugin source and deprecate config * Remove code plugin docs * Remove xpack.code translations * Remove code import on api_integration * Remove code privilege from security test * remove two more mentions of code * remove code es_archives * remove code doc images

narcher7 · 2019-11-07T15:40:28Z

@epixa: Late to the game on this one, but do we plan on backporting this change all the way back to 7.2 when the Code app was introduced?

epixa · 2019-11-11T14:16:30Z

@Donnater No. Those versions are no longer maintained, so they won't be getting new releases. We could technically still do this in 7.4 since that is still maintained, but we'd prefer not to do this in a patch release. The code plugin is disabled by default in those versions, so most people don't use it anyway.

narcher7 · 2019-11-11T20:00:40Z

@epixa: The issue is that the Code docs are still listed in those older versions. I can try to make a pull request that just pulls out docs, but would it be possible to just cherry-pick the doc related commits from this PR and just push those down to 7.4 and 7.3?

tylersmalley · 2019-11-11T20:30:44Z

@Donnater, is there a reason we want to remove the docs for the versions it's in? For users who might be using Code in one of those versions, I think it's fair that they should still have access to those docs.

narcher7 · 2019-11-18T19:35:02Z

@tylersmalley: Not a good reason besides consistency.

General question to the group, is there a need to add this to the breaking changes list of 7.5?

How many people were actually using the code app before we switched it off?

epixa · 2019-11-18T20:44:55Z

Yes, I should have included that in the original PR. I'll submit breaking change docs for this today or first thing tomorrow.

willemdh · 2019-12-10T09:17:32Z

Sad to see this feature go. We really liked to Kibana Code application to search in all our git repo's.

epixa added 5 commits October 25, 2019 16:23

Fix erroneous code plugin import in apm

95f8a23

Remove code plugin docs

447c1ed

Stop running legacy code plugin

95a5400

Stop testing code app and apis

8ce1538

Remove code plugin source and deprecate config

dc34f17

epixa added release_note:enhancement release_note:breaking v8.0.0 v7.5.0 Team:Code labels Oct 25, 2019

Remove xpack.code translations

342085e

This comment has been minimized.

Sign in to view

Merge branch 'master' into remove-code

5d8bdae

This comment has been minimized.

Sign in to view

epixa added 2 commits October 25, 2019 21:43

Remove code import on api_integration

ea39fa9

Remove code privilege from security test

cd15d71

This comment has been minimized.

Sign in to view

spalger added 3 commits October 25, 2019 23:52

remove two more mentions of code

91e8381

remove code es_archives

f8e9e4c

remove code doc images

6508027

sorenlouv approved these changes Oct 26, 2019

View reviewed changes

epixa added the review label Oct 26, 2019

epixa requested review from a team as code owners October 26, 2019 11:27

spalger approved these changes Oct 26, 2019

View reviewed changes

snide approved these changes Oct 26, 2019

View reviewed changes

This was referenced Oct 27, 2019

[Code] Search Commit history #48036

Closed

APM/Code Imports #48708

Closed

Merge branch 'master' into remove-code

9c335ff

tylersmalley approved these changes Oct 28, 2019

View reviewed changes

kobelb approved these changes Oct 28, 2019

View reviewed changes

epixa merged commit 0b82cfe into elastic:master Oct 28, 2019

epixa deleted the remove-code branch October 28, 2019 15:40

epixa mentioned this pull request Oct 28, 2019

[7.x] Remove experimental code app (#49404) #49488

Merged

epixa added v7.6.0 v7.5.0 and removed v7.5.0 labels Oct 28, 2019

epixa mentioned this pull request Oct 28, 2019

[7.5] Remove experimental code app (#49404) #49527

Merged

epixa mentioned this pull request Nov 19, 2019

[DOCS] Code app removal in breaking changes documentation #51074

Merged

kobelb mentioned this pull request Sep 18, 2020

Removing the code plugin entirely for 8.0 #77940

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove experimental code app #49404

Remove experimental code app #49404

epixa commented Oct 25, 2019 •

edited

Loading

elasticmachine commented Oct 25, 2019

tylersmalley commented Oct 25, 2019

epixa commented Oct 25, 2019 •

edited

Loading

epixa commented Oct 25, 2019

This comment has been minimized.

This comment has been minimized.

epixa commented Oct 26, 2019

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

elasticmachine commented Oct 26, 2019

spalger left a comment •

edited

Loading

snide left a comment

elasticmachine commented Oct 28, 2019

epixa commented Oct 28, 2019

narcher7 commented Nov 7, 2019

epixa commented Nov 11, 2019

narcher7 commented Nov 11, 2019

tylersmalley commented Nov 11, 2019

narcher7 commented Nov 18, 2019

epixa commented Nov 18, 2019

willemdh commented Dec 10, 2019

Remove experimental code app #49404

Remove experimental code app #49404

Conversation

epixa commented Oct 25, 2019 • edited Loading

Summary

elasticmachine commented Oct 25, 2019

tylersmalley commented Oct 25, 2019

epixa commented Oct 25, 2019 • edited Loading

epixa commented Oct 25, 2019

This comment has been minimized.

This comment has been minimized.

epixa commented Oct 26, 2019

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

elasticmachine commented Oct 26, 2019

💚 Build Succeeded

spalger left a comment • edited Loading

Choose a reason for hiding this comment

snide left a comment

Choose a reason for hiding this comment

elasticmachine commented Oct 28, 2019

💚 Build Succeeded

epixa commented Oct 28, 2019

narcher7 commented Nov 7, 2019

epixa commented Nov 11, 2019

narcher7 commented Nov 11, 2019

tylersmalley commented Nov 11, 2019

narcher7 commented Nov 18, 2019

epixa commented Nov 18, 2019

willemdh commented Dec 10, 2019

epixa commented Oct 25, 2019 •

edited

Loading

epixa commented Oct 25, 2019 •

edited

Loading

spalger left a comment •

edited

Loading