Flaky test runner improvements/fixes #49367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianseeders
added
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
wayneseymour
approved these changes
Oct 25, 2019
💚 Build Succeeded |
|
@elasticmachine merge upstream |
💚 Build Succeeded |
💚 Build Succeeded |
|
@elasticmachine merge upstream |
💚 Build Succeeded |
| for(def agentNumber = 1; agentNumber <= agentCount; agentNumber++) { | ||
| for(def agentNumber = 1; agentNumber <= AGENT_COUNT; agentNumber++) { | ||
| def agentNumberInside = agentNumber | ||
| def agentExecutions = floor(EXECUTIONS/AGENT_COUNT) + (agentNumber <= EXECUTIONS%AGENT_COUNT ? 1 : 0) |
There was a problem hiding this comment.
Would this be better as a closure or method with a name?
No big deal, but names are quicker to grok, vs not being able to be lazy and having to read the code lol ahahahaa
wayneseymour
approved these changes
Oct 30, 2019
brianseeders
added a commit
to brianseeders/kibana
that referenced
this pull request
Nov 26, 2019
* Allocate multiple flaky test runner agents as executions grow * WIP support for deleting kibana install dir during CI * Add setup script for testing scripts * Add REMOVE_KIBANA_INSTALL_DIR=1 to flaky test runner * Change flaky test runner worker processes from 8 to 12
brianseeders
added a commit
that referenced
this pull request
Dec 2, 2019
* Re-add pipeline for flaky test runner job (#48781) * Revert "Revert "Add pipeline for flaky test runner job (#46740)"" This reverts commit 7d96a13. Also reconcile changes to Jenkinsfile since original revert happened * Fix param parsing and add missed change * Add missing variable * Retry git clone up to 8 times before failing a build (#50734) * Flaky test runner improvements/fixes (#49367) * Allocate multiple flaky test runner agents as executions grow * WIP support for deleting kibana install dir during CI * Add setup script for testing scripts * Add REMOVE_KIBANA_INSTALL_DIR=1 to flaky test runner * Change flaky test runner worker processes from 8 to 12 * Add labels to shell scripts in Jenkins (#49657) * Change pipeline timeout from 3 hours to 2 hours (#51098) * Remove flaky pipeline step not relevant for 6.8 * Re-add failed_tests cli * Fix PARALLEL_PIPELINE_WORKER_INDEX var
brianseeders
added a commit
to brianseeders/kibana
that referenced
this pull request
Jan 13, 2020
* Allocate multiple flaky test runner agents as executions grow * WIP support for deleting kibana install dir during CI * Add setup script for testing scripts * Add REMOVE_KIBANA_INSTALL_DIR=1 to flaky test runner * Change flaky test runner worker processes from 8 to 12
brianseeders
added a commit
to brianseeders/kibana
that referenced
this pull request
Jan 13, 2020
* Allocate multiple flaky test runner agents as executions grow * WIP support for deleting kibana install dir during CI * Add setup script for testing scripts * Add REMOVE_KIBANA_INSTALL_DIR=1 to flaky test runner * Change flaky test runner worker processes from 8 to 12
brianseeders
added a commit
that referenced
this pull request
Jan 13, 2020
* Allocate multiple flaky test runner agents as executions grow * WIP support for deleting kibana install dir during CI * Add setup script for testing scripts * Add REMOVE_KIBANA_INSTALL_DIR=1 to flaky test runner * Change flaky test runner worker processes from 8 to 12
brianseeders
added a commit
that referenced
this pull request
Jan 13, 2020
* Allocate multiple flaky test runner agents as executions grow * WIP support for deleting kibana install dir during CI * Add setup script for testing scripts * Add REMOVE_KIBANA_INSTALL_DIR=1 to flaky test runner * Change flaky test runner worker processes from 8 to 12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test/scripts/jenkins_test_setup.shRemoving kibana install dirs is pretty much required for the flaky test runner to work correctly, now that we're mounting the workspace in memory