Skip to content

[ML] Combines ui/time_buckets into MlTimeBuckets #46227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 25, 2019
Merged

[ML] Combines ui/time_buckets into MlTimeBuckets #46227

merged 3 commits into from
Sep 25, 2019

Conversation

@peteharverson
Copy link
Contributor

@peteharverson peteharverson commented Sep 20, 2019 •
edited
Loading

Summary

ML was making heavy use of the Kibana TimeBuckets object (ui/time_buckets), in calculating the aggregation interval for time series charts. This was both through direct use, and with the MlTimeBuckets object which inherited from TimeBuckets but with added functionality for setting the number of bars to target in the chart.

As discussed in #44249, in preparation for the new platform Kibana TimeBuckets will become part of the data plugin, and won't be exposed as an API. This PR therefore copies into ml_time_buckets.js the parts of TimeBuckets from ui/time_buckets which were being inherited, and switches all usage in the ML plugin to MlTimeBuckets.

The code has been copied in unchanged, apart from dropping the cache object which was used in the Kibana TimeBuckets.

Checklist

Fixes #44249

@peteharverson peteharverson requested a review from a team as a code owner September 20, 2019 13:19
@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 20, 2019

Pinging @elastic/ml-ui

@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 20, 2019

💚 Build Succeeded

walterra
walterra reviewed Sep 24, 2019
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good for this PR. Just a question about copying over the code: Does the original time buckets code maybe have more test coverage we could also bring over?

@peteharverson
Copy link
Contributor Author

peteharverson commented Sep 24, 2019

@walterra there wasn't any test coverage for the original time_buckets.js code, and we already have good coverage for ml_time_buckets.js in /ml/public/util/__tests__/ml_time_buckets.js. However I notice we don't have any coverage for ml_calc_auto_interval.js, which is used in place of the Kibana calc_auto_interval, so I will look at adding some coverage for that.

walterra
walterra approved these changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jgowdyelastic
jgowdyelastic approved these changes Sep 24, 2019
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and LGTM
As the original kibana TimeBuckets is being removed, is it worth just renaming this just to TimeBuckets rather than MlTimeBuckets?

@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 24, 2019

💚 Build Succeeded

@jgowdyelastic
Copy link
Member

jgowdyelastic commented Sep 25, 2019

Still LGTM

@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 25, 2019

💚 Build Succeeded

@peteharverson peteharverson merged commit 0fae8ce into elastic:master Sep 25, 2019
@peteharverson peteharverson deleted the ml-time-buckets branch September 25, 2019 16:00
@peteharverson peteharverson mentioned this pull request Sep 25, 2019
Merged
peteharverson added a commit to peteharverson/kibana that referenced this pull request Sep 25, 2019
@peteharverson
[ML] Combines ui/time_buckets into MlTimeBuckets (elastic#46227)
022c1d6 
* [ML] Combines ui/time_buckets into MlTimeBuckets

* [ML] Add unit tests for ml calc_auto_interval

* [ML] Rename MlTimeBuckets to TimeBuckets
peteharverson added a commit that referenced this pull request Sep 25, 2019
@peteharverson
[ML] Combines ui/time_buckets into MlTimeBuckets (#46227) (#46606)
a7981fc 
* [ML] Combines ui/time_buckets into MlTimeBuckets

* [ML] Add unit tests for ml calc_auto_interval

* [ML] Rename MlTimeBuckets to TimeBuckets
@peteharverson peteharverson mentioned this pull request Oct 30, 2019
Closed
78 tasks
@walterra walterra mentioned this pull request Mar 14, 2024
Merged
2 tasks
walterra added a commit that referenced this pull request Mar 20, 2024
@walterra
[ML] Consolidate redundant time_buckets into @kbn/ml-time-buckets. (
be9ad68 
#178756)

## Summary

Follow up to #46227.

Consolidates multiple copies of `time_buckets.js` into
`@kbn/ml-time-buckets`. The scope of this PR is just to consolidate the
files. In follow ups we still need to: Refactor JS to TS and get rid of
the code that uses this using "dependency cache" in the `ml` plugin.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@walterra walterra walterra approved these changes

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

Assignees

No one assigned

Labels

chore Feature:NP Migration :ml release_note:skip Skip the PR/issue when compiling release notes review v7.5.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ML] Copy over TimeBuckets into ML code

4 participants

@peteharverson @elasticmachine @jgowdyelastic @walterra