Move angel values into vis rendering code #43968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sulemanof
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-app |
Contributor
💚 Build Succeeded |
maryia-lapata
approved these changes
Aug 28, 2019
Contributor
Author
|
@flash1293 are you ok with these changes? 😊 |
flash1293
approved these changes
Aug 28, 2019
Contributor
flash1293
left a comment
flash1293
left a comment
There was a problem hiding this comment.
Code LGTM - really good simplification 👍
…gel_values # Conflicts: # src/legacy/core_plugins/kbn_vislib_vis_types/public/components/options/gauge/style_panel.tsx
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
sulemanof
added a commit
to sulemanof/kibana
that referenced
this pull request
Aug 28, 2019
* Move angel values into vis rendering code * Remove unused type
sulemanof
added a commit
that referenced
this pull request
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is based on the discussion while
EUIficationof theGaugeoptions.Get rid of setting
minAngelandmaxAngelinside theoptionseditor and move the logic straight to visualization renderer.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers