-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Watcher] Handle 403 and 404 in Status and Edit routes and fix breadcrumbs #35444
Merged
cjcenizal
merged 11 commits into
elastic:watcher-port
from
cjcenizal:watcher/forbidden-state
Apr 23, 2019
Merged
[Watcher] Handle 403 and 404 in Status and Edit routes and fix breadcrumbs #35444
cjcenizal
merged 11 commits into
elastic:watcher-port
from
cjcenizal:watcher/forbidden-state
Apr 23, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
added
non-issue
Indicates to automation that a pull request should not appear in the release notes
Feature:Watcher
Team:Kibana Management
Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
labels
Apr 23, 2019
Pinging @elastic/es-ui |
cjcenizal
changed the title
Watcher/forbidden state
[Watcher] Handle 403s in Status and Edit routes
Apr 23, 2019
…WatchList, WatchStatus, and WatchEdit.
cjcenizal
force-pushed
the
watcher/forbidden-state
branch
from
April 23, 2019 04:52
671c596
to
85b005a
Compare
💔 Build Failed |
💔 Build Failed |
… to surface 404 errors.
cjcenizal
changed the title
[Watcher] Handle 403s in Status and Edit routes
[Watcher] Handle 403 and 404 in Status and Edit routes
Apr 23, 2019
cjcenizal
changed the title
[Watcher] Handle 403 and 404 in Status and Edit routes
[Watcher] Handle 403 and 404 in Status and Edit routes and fix breadcrumbs
Apr 23, 2019
💔 Build Failed |
bmcconaghy
approved these changes
Apr 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thx for all the fixes
alisonelizabeth
approved these changes
Apr 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Watcher
non-issue
Indicates to automation that a pull request should not appear in the release notes
Team:Kibana Management
Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user lacks permissions to manage watches, they'll see some feedback and be blocked from using the UI:
Currently, this only works for the edit and status routes. There's code in place to do this for the list route, but it looks like the API for fetching and listing all watches is just a simple search, and it doesn't look like the user's watch permissions affect this query. I'll follow up with the Watcher API team on this.
I also added feedback for when the API responds with a 404: