Move search bar into data plugin #35389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Pinging @elastic/kibana-app-arch |
lizozom
force-pushed
the
newplatform/data-plugin/search-bar
branch
from
ac66029 to
2be188f
Compare
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
…plugin/search-bar
Contributor
💔 Build Failed |
added 2 commits
April 24, 2019 11:01
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
This was referenced Apr 26, 2019
lukeelmers
reviewed
Apr 26, 2019
Member
lukeelmers
left a comment
lukeelmers
left a comment
There was a problem hiding this comment.
Overall looks great! Thanks for separating this out into its own PR, makes things much easier :) Added a couple thoughts.
One thing I'm thinking is, if we are actually moving ui/search_bar in this PR, we should probably add developer documentation for that. I've started this here -- would you mind updating it for any subsequent PRs that remove directories like this?
src/legacy/core_plugins/data/public/index_patterns/index_patterns_service.ts
Outdated
Show resolved
Hide resolved
src/legacy/core_plugins/data/public/search_bar/search_bar_service.ts
Outdated
Show resolved
Hide resolved
lukeelmers
added
the
release_note:skip
added 3 commits
April 29, 2019 14:27
…plugin/search-bar
…newplatform/data-plugin/search-bar
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💚 Build Succeeded |
added 2 commits
April 30, 2019 16:06
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
…plugin/search-bar
Contributor
💔 Build Failed |
…plugin/search-bar
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
lukeelmers
approved these changes
May 1, 2019
lizozom
added a commit
to lizozom/kibana
that referenced
this pull request
May 2, 2019
* Moved filter bar to data plugin (still not working) * Moved filter options from search bar into filter bar
lizozom
added a commit
that referenced
this pull request
May 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moved search bar to data plugin.
Incl. moving FilterOptions to the filter component
FilterOptions:
This is split from #35300
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibility