New platform move doc table and doc viewer to kibana\discover #34231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94 tasks
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
lizozom
added
Feature:New Platform
Team:Visualizations
Contributor
|
Pinging @elastic/kibana-app |
cchaos
approved these changes
Apr 1, 2019
added 3 commits
April 2, 2019 13:34
…-doc-table-to-discover
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
added 2 commits
April 3, 2019 12:00
Contributor
Author
|
Discover technically supports showing paginated results (instead of an infinite scroll) @stacey-gammon (your name is on that line) @AlonaNadler https://github.com/elastic/kibana/search?q=infiniteScroll&unscoped_q=infiniteScroll |
Contributor
💚 Build Succeeded |
lukeelmers
approved these changes
Apr 5, 2019
Member
lukeelmers
left a comment
lukeelmers
left a comment
There was a problem hiding this comment.
LGTM! Just had one question
src/legacy/core_plugins/kibana/public/discover/doc_table/components/table_row.js
Show resolved
Hide resolved
…-doc-table-to-discover
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💚 Build Succeeded |
lizozom
added a commit
to lizozom/kibana
that referenced
this pull request
Apr 7, 2019
…c#34231) * Moved doc table to kibana/discover * moved doc viewer to Kibana app (used by docs and discover) * Moved - saved object finder - paginated selectable list from partiasls to directives/partials * Moved paginate controls directive to directives/partials
lizozom
added a commit
that referenced
this pull request
Apr 7, 2019
#34678) * Moved doc table to kibana/discover * moved doc viewer to Kibana app (used by docs and discover) * Moved - saved object finder - paginated selectable list from partiasls to directives/partials * Moved paginate controls directive to directives/partials
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moved
doc tableanddoc viewerfrom ui/public to kibana pluginChecklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibility