Remove plugin legacy/ui/public/jquery #33855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
💔 Build Failed |
rudolf
force-pushed
the
remove-ui-jquery
branch
from
f7ab852 to
7232956
Compare
Contributor
💔 Build Failed |
rudolf
force-pushed
the
remove-ui-jquery
branch
from
7232956 to
75c8402
Compare
Contributor
💔 Build Failed |
rudolf
force-pushed
the
remove-ui-jquery
branch
from
75c8402 to
81ed183
Compare
Contributor
💚 Build Succeeded |
rudolf
added
review
Team:Core
Contributor
|
Pinging @elastic/kibana-platform |
rudolf
added
the
non-issue
rudolf
added a commit
to rudolf/kibana
that referenced
this pull request
Mar 28, 2019
rudolf
added a commit
that referenced
this pull request
Mar 29, 2019
94 tasks
epixa
added
the
release_note:plugin_api_changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In preparation for new platform deprecating public/ui, this removes the
src/legacy/ui/public/jqueryplugin that was a thin convenience wrapper around'@kbn/test-subj-selector'.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This includes a feature addition or change that requires a release note and was labeled appropriately