Deleted unused directives from angular-boostrap #33564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- alert - pagination - pager - bar - tooltipPopup - tooltipHtmlUnsafePopup
lizozom
changed the title
lizozom
added
Feature:New Platform
Team:Visualizations
Contributor
|
Pinging @elastic/kibana-app |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
- Removed ui-bootstrap-custom (Sense directives that are not used) - Moved $position service into tooltip folder (as it's the only thing using it) - Removed progress directive - Removed typeahead, typeaheadPopup, typeaheadMatch, typeaheadHighlight directives
Contributor
Author
|
@spalger this has a lot of old (and sensitive?) code removal, so I'd love your feedback |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
Contributor
Contributor
|
Remove away! |
lizozom
added a commit
to lizozom/kibana
that referenced
this pull request
Mar 24, 2019
* Deleted unused directives - alert - pagination - pager - bar - tooltipPopup - tooltipHtmlUnsafePopup
lizozom
added a commit
that referenced
this pull request
Mar 24, 2019
94 tasks
joelgriffith
pushed a commit
that referenced
this pull request
Mar 27, 2019
* Deleted unused directives - alert - pagination - pager - bar - tooltipPopup - tooltipHtmlUnsafePopup
Contributor
|
This is so great to see. I've been looking forward to this day for the past 3 years. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removed:
please ignore whitespace differences in progressbar related files. They are deleted in a subsequent PR
Moved
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibility