[Logs UI] Fix font size references after EUI upstream change #33411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weltenwort
added
bug
Contributor
|
Pinging @elastic/infrastructure-ui |
Contributor
💚 Build Succeeded |
skh
approved these changes
Mar 18, 2019
Contributor
skh
left a comment
skh
left a comment
There was a problem hiding this comment.
Reproduced the issue on master, verified the fix in this branch. 👍
weltenwort
added a commit
to weltenwort/kibana
that referenced
this pull request
Mar 18, 2019
…#33411) This fixes the `small` font scale of the log viewer to correctly reference the EUI font size again. Before this fix, the `small` font scale was rendered larger than `medium`. Similarly, the tick labels of the log minimap were being rendered too large. Both resulted from a breaking change of the exported variable names in elastic/eui#1590. fixes elastic#32759
Contributor
💚 Build Succeeded |
weltenwort
added a commit
that referenced
this pull request
Mar 18, 2019
weltenwort
added
the
non-issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the
smallfont scale of the log viewer to correctly reference the EUI font size again. Before this fix, thesmallfont scale was rendered larger thanmedium. Similarly, the tick labels of the log minimap were being rendered too large.Both resulted from a breaking change of the exported variable names in elastic/eui#1590.
fixes #32759
Checklist
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This was checked for breaking API changes and was labeled appropriatelyThis includes a feature addition or change that requires a release note and was labeled appropriately