[APM] useFetcher: Replace react-redux-request with hooks and Context API #33392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorenlouv
commented
Mar 18, 2019
💔 Build Failed |
💚 Build Succeeded |
This was referenced Mar 18, 2019
jasonrhodes
reviewed
Mar 19, 2019
1 task
💔 Build Failed |
sorenlouv
force-pushed
the
add-useFetcher-hook
branch
from
fae8c82
to
df70310
Compare
💚 Build Succeeded |
💚 Build Succeeded |
💔 Build Failed |
|
This is a great hook. I especially like how it only refetches when there are changes in the options object. LGTM! |
sorenlouv
force-pushed
the
add-useFetcher-hook
branch
from
dd920c6
to
fd1cb71
Compare
💚 Build Succeeded |
💔 Build Failed |
sorenlouv
force-pushed
the
add-useFetcher-hook
branch
from
12b93ac
to
8ee4cad
Compare
💔 Build Failed |
💔 Build Failed |
sorenlouv
force-pushed
the
add-useFetcher-hook
branch
2 times, most recently
from
83aa30a
to
233e6c8
Compare
💚 Build Succeeded |
sorenlouv
force-pushed
the
add-useFetcher-hook
branch
from
233e6c8
to
5e0bb4a
Compare
💚 Build Succeeded |
💚 Build Succeeded |
💔 Build Failed |
💔 Build Failed |
Fix test Address feedback [APM] Add useFetcher to ServiceOverview, and add `react-testing-library` Fix tests Make spec descriptions more clear [APM] Add useFetcher to serviceDetailsView Fix tests Add redirect Fix snapshot Fix redirect to correct bucket Convert TransactionDetails [APM] Fix Datepicker double loading and move date parsing to urlParams Convert more to hooks Revert "[APM] Fix Datepicker double loading and move date parsing to urlParams" This reverts commit ed41e17.
sorenlouv
force-pushed
the
add-useFetcher-hook
branch
from
556e1b3
to
5612dc7
Compare
💚 Build Succeeded |
jasonrhodes
approved these changes
Mar 28, 2019
It totally would have! Will add a test for that case now, and then merge. |
💚 Build Succeeded |
💚 Build Succeeded |
sorenlouv
added a commit
to sorenlouv/kibana
that referenced
this pull request
Mar 29, 2019
…API (elastic#33392) # Conflicts: # x-pack/package.json # yarn.lock
sorenlouv
added a commit
that referenced
this pull request
Mar 29, 2019
This was referenced Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First steps towards replacing react-redux-request with a custom hook. This PR just replaces rrr for the error overview and error details page.
Why Context API and hooks instead of Redux and react-redux-request (RRR: custom render prop component for data fetching)?
useFetchhook, the state is local by default by default but can easily be lifted up with the context API.Tip: Setting the diff settings to "Hide whitespace changes" will make this a fair bit easier to review.