moved btn-radio directive to vis editor #33373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizozom
added
Feature:New Platform
Team:Visualizations
Contributor
|
Pinging @elastic/kibana-app |
Contributor
|
Pinging @elastic/es-ui |
Contributor
💚 Build Succeeded |
mattkime
approved these changes
Mar 20, 2019
Contributor
mattkime
left a comment
mattkime
left a comment
There was a problem hiding this comment.
Looks good! I grepped the codebase to find other cases and verified that you found them all.
lizozom
added a commit
to lizozom/kibana
that referenced
this pull request
Mar 20, 2019
lizozom
added a commit
that referenced
this pull request
Mar 20, 2019
cjcenizal
removed
the
Team:Kibana Management
Contributor
|
@lizozom Would you mind adding a release note label to this PR? |
lizozom
added
the
release_note:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moved directives used only by vis editor into it's folder
Moved btnRadio directive
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibility