-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Adds anomaly time to aria label for anomalies table actions button #32777
[ML] Adds anomaly time to aria label for anomalies table actions button #32777
Conversation
Pinging @elastic/ml-ui |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💔 Build Failed |
retest |
💔 Build Failed |
💚 Build Succeeded |
…on (elastic#32777) * [ML] Adds anomaly time to aria label for anomalies table actions button * [ML] Update CHinese translation for edited table actions button
…on (elastic#32777) * [ML] Adds anomaly time to aria label for anomalies table actions button * [ML] Update CHinese translation for edited table actions button
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bit late but LGTM ⚡️
Summary
Adds the time of the anomaly to the
aria-label
of the actions button in each row of the anomalies table to provide extra context of the row the action is on. Screen reader now announces e.g.Select action for anomaly at November 11th 2018, 22:30:00
Checklist
For maintainers
Fixes #31103