Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Design - General layout updates #32750

Merged
merged 5 commits into from
Mar 8, 2019

Conversation

formgeist
Copy link
Contributor

Summary

To better match the general styleguide of K7, I've made some fundamental layout changes to the app. Primarily paneling our graphs and tables and replacing the white background colour. This creates depth and frames each component on the page.

screencapture-localhost-5601-znv-app-apm-2019-03-08-11_26_02

screencapture-localhost-5601-znv-app-apm-2019-03-08-11_26_20

screencapture-localhost-5601-znv-app-apm-2019-03-08-11_30_49

screencapture-localhost-5601-znv-app-apm-2019-03-08-11_26_26

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@formgeist formgeist added the Team:APM All issues that need APM UI Team support label Mar 8, 2019
@formgeist formgeist self-assigned this Mar 8, 2019
@formgeist formgeist requested review from makwarth and a team March 8, 2019 10:32
@formgeist formgeist requested a review from a team as a code owner March 8, 2019 10:32
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo no more white background! Screenshots and less one line of css LGTM!

Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job @formgeist!
Are those screenshots really our app and not mocks? Looks great!

@makwarth
Copy link

makwarth commented Mar 8, 2019

Whoa, this made my day! :) We've been working out of K7 mockups for 18 months, so to see it all come to life now is an amazing milesone. Great work everyone! (I'm on the road so no able to run this locally for review)

@makwarth
Copy link

makwarth commented Mar 8, 2019

Just had a thought: I'd be cool to blog about the design progress of the APM UI - from its release in 6.1 to now in 7.0. We have release screenshots from each release blog post, so shouldn't take long to put together. It's a great way of showing off the Design team's work, and the pace of the APM product development.
/cc @jamiesmith @nehaduggal @tbragin

@jasonrhodes
Copy link
Member

oh thank GOD we got those charts back in the boxes, that's been bothering me since we released metrics! Looks great, nice work 👏

@jamiesmith
Copy link
Contributor

jamiesmith commented Mar 8, 2019 via email

@formgeist
Copy link
Contributor Author

I can put the image content together at the very least and probably right about some of the challenges and decisions made with those first releases.

@tbragin
Copy link
Contributor

tbragin commented Mar 8, 2019

@makwarth I added to the observability blogs ideas. We can discuss who is best positioned to write this blog.

formgeist added a commit that referenced this pull request Mar 11, 2019
* Remove default background color

* Wrapping graphs and tables in EuiPanel

* Adding titles to Transactions and Errors list tables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:APM All issues that need APM UI Team support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants