-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Design - General layout updates #32750
Conversation
Pinging @elastic/apm-ui |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woohoo no more white background! Screenshots and less one line of css LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job @formgeist!
Are those screenshots really our app and not mocks? Looks great!
Whoa, this made my day! :) We've been working out of K7 mockups for 18 months, so to see it all come to life now is an amazing milesone. Great work everyone! (I'm on the road so no able to run this locally for review) |
Just had a thought: I'd be cool to blog about the design progress of the APM UI - from its release in 6.1 to now in 7.0. We have release screenshots from each release blog post, so shouldn't take long to put together. It's a great way of showing off the Design team's work, and the pace of the APM product development. |
oh thank GOD we got those charts back in the boxes, that's been bothering me since we released metrics! Looks great, nice work 👏 |
I like it.
You could even spice it up with some of the wireframes that you made
|
I can put the image content together at the very least and probably right about some of the challenges and decisions made with those first releases. |
@makwarth I added to the observability blogs ideas. We can discuss who is best positioned to write this blog. |
Summary
To better match the general styleguide of K7, I've made some fundamental layout changes to the app. Primarily paneling our graphs and tables and replacing the white background colour. This creates depth and frames each component on the page.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This was checked for breaking API changes and was labeled appropriatelyThis includes a feature addition or change that requires a release note and was labeled appropriately