[Canvas] Restores delete as osx shortcut for deleting elements #32704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cqliu1
added
review
v7.0.0
Team:Presentation
|
Pinging @elastic/kibana-canvas |
cqliu1
changed the title
del as osx shortcut for deleting elements
💚 Build Succeeded |
cqliu1
added a commit
to cqliu1/kibana
that referenced
this pull request
Mar 7, 2019
cqliu1
added a commit
to cqliu1/kibana
that referenced
this pull request
Mar 7, 2019
cqliu1
added a commit
to cqliu1/kibana
that referenced
this pull request
Mar 7, 2019
cqliu1
added a commit
that referenced
this pull request
Mar 7, 2019
cqliu1
added a commit
that referenced
this pull request
Mar 7, 2019
cqliu1
added a commit
to cqliu1/kibana
that referenced
this pull request
Mar 8, 2019
cqliu1
added a commit
that referenced
this pull request
Mar 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #32698. This restores
del(i.e.fn+backspace) to MacOS shortcut for deleting elements. This also extracts repeated shortcuts to variables.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenariosFor maintainers