Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Remove gutter from advanced settings code blocks #32700

Merged
merged 2 commits into from
Mar 7, 2019
Merged

[Fix] Remove gutter from advanced settings code blocks #32700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b08282e
Remove gutter from advanced settings code blocks
cchaos Mar 7, 2019
13761ac
oh snap!
cchaos Mar 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...ana/public/management/sections/settings/components/field/__snapshots__/field.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1296,6 +1296,7 @@ exports[`Field for json setting should render as read only with help text if ove
"tabSize": 2,
}
}
showGutter={false}
theme="textmate"
value="{\\"hello\\": \\"world\\"}"
width="100%"
Expand Down Expand Up @@ -1398,6 +1399,7 @@ exports[`Field for json setting should render custom setting icon if it is custo
"tabSize": 2,
}
}
showGutter={false}
theme="textmate"
value="{\\"foo\\": \\"bar\\"}"
width="100%"
Expand Down Expand Up @@ -1535,6 +1537,7 @@ exports[`Field for json setting should render default value if there is no user
"tabSize": 2,
}
}
showGutter={false}
theme="textmate"
value="{\\"foo\\": \\"bar\\"}"
width="100%"
Expand Down Expand Up @@ -1672,6 +1675,7 @@ exports[`Field for json setting should render user value if there is user value
"tabSize": 2,
}
}
showGutter={false}
theme="textmate"
value="{\\"hello\\": \\"world\\"}"
width="100%"
Expand Down Expand Up @@ -1797,6 +1801,7 @@ exports[`Field for markdown setting should render as read only with help text if
"tabSize": 2,
}
}
showGutter={false}
theme="textmate"
value="**bold**"
width="100%"
Expand Down Expand Up @@ -1899,6 +1904,7 @@ exports[`Field for markdown setting should render custom setting icon if it is c
"tabSize": 2,
}
}
showGutter={false}
theme="textmate"
value=""
width="100%"
Expand Down Expand Up @@ -1990,6 +1996,7 @@ exports[`Field for markdown setting should render default value if there is no u
"tabSize": 2,
}
}
showGutter={false}
theme="textmate"
value=""
width="100%"
Expand Down Expand Up @@ -2123,6 +2130,7 @@ exports[`Field for markdown setting should render user value if there is user va
"tabSize": 2,
}
}
showGutter={false}
theme="textmate"
value="**bold**"
width="100%"
Expand Down
2 changes: 1 addition & 1 deletion src/legacy/core_plugins/kibana/public/management/sections/settings/components/field/field.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@ class FieldUI extends PureComponent {
editorProps={{
$blockScrolling: Infinity
}}

showGutter={false}
/>
</div>
);
Expand Down
5 changes: 1 addition & 4 deletions src/legacy/ui/public/styles/_legacy/components/_ace_overrides.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,6 @@
overflow: visible;
}

.ace_scroller {
border-left: $euiBorderThin;
}

.ace_warning {
color: $euiColorDanger;
}
Expand All @@ -70,6 +66,7 @@
.ace_gutter {
background-color: $euiColorEmptyShade;
color: $euiColorDarkShade;
border-left: 1px solid $aceBackground;
}

.ace_print-margin {
Expand Down