Fix missing axis labels when moving position #32628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded |
|
@flash1293 We should probably backport all the way to 6.7 for inclusion in 6.7.1, though you’ll need to wait to merge that until the final 6.7 release is cut, since this isn’t a blocker. I’m not sure if this issue qualifies for backport to 6.6 though... I’d defer to @LeeDr on that |
timroes
added
Feature:Vislib
|
Pinging @elastic/kibana-app |
timroes
approved these changes
Mar 11, 2019
timroes
pushed a commit
to timroes/kibana
that referenced
this pull request
Mar 11, 2019
timroes
pushed a commit
to timroes/kibana
that referenced
this pull request
Mar 11, 2019
timroes
pushed a commit
to timroes/kibana
that referenced
this pull request
Mar 11, 2019
timroes
added a commit
that referenced
this pull request
Mar 11, 2019
timroes
added a commit
that referenced
this pull request
Mar 11, 2019
timroes
added a commit
that referenced
this pull request
Mar 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32059
The counter for the current position of the axis label during filtering didn't work correctly for vertical axes. I couldn't find another place which triggered this branch but the one outlined in the issue.
@lukeelmers Do you know how far we should backport this by any chance?