[New platform] Expose NP core services and plugins contracts to the legacy server #32468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshustov
added
Team:Core
|
Pinging @elastic/kibana-platform |
mshustov
changed the title
mshustov
commented
Mar 5, 2019
| * @param kbnServer KbnServer singleton instance. | ||
| * @param server Hapi server instance to expose `core` on. | ||
| */ | ||
| export function coreMixin(kbnServer: KbnServer, server: Server) { | ||
| server.decorate('server', 'core', kbnServer.core); |
There was a problem hiding this comment.
to avoid confusion I removed this escape hatch, let me know if we want to keep it and revert the commit
💔 Build Failed |
mshustov
force-pushed
the
issue-32395-server-side
branch
from
bfccecf
to
0a5ac14
Compare
💔 Build Failed |
|
retest |
💚 Build Succeeded |
💚 Build Succeeded |
epixa
reviewed
Mar 5, 2019
💔 Build Failed |
|
still have a problem with build. Feel free to review. If I don't have a solution tomorrow, I will revert the last commit with adding typings for |
epixa
approved these changes
Mar 6, 2019
|
wait for #32578 to address the problem with importing types |
💔 Build Failed |
💚 Build Succeeded |
mshustov
added a commit
to mshustov/kibana
that referenced
this pull request
Mar 7, 2019
…egacy server (elastic#32468) * expose NewPlatform core and plugins to legacy server * get rid of .core in favor of .newPlatform * decalre start/stop contract explicitly * expose newPlatform typings * Remove dependency on legacy package_json util from core * Remove dependencies on core/server in core/types
epixa
pushed a commit
that referenced
this pull request
Mar 7, 2019
…egacy server (#32468) (#32666) * expose NewPlatform core and plugins to legacy server * get rid of .core in favor of .newPlatform * decalre start/stop contract explicitly * expose newPlatform typings * Remove dependency on legacy package_json util from core * Remove dependencies on core/server in core/types
epixa
added
the
release_note:plugin_api_changes
💔 Build Failed |
💔 Build Failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue #32395
Expose New Platform core services and plugins contracts to the legacy server
Functionality is covered in
test:serverChecklist
[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
Dev Docs
Expose New Platform core services and plugins contracts to the legacy server
Kibana is in process of stabilizing of API. During this release, our primary focus was on formalizing API for main core services. Although this is still an experimental API, you can have access to updated elasticsearch and http services on the server side via
kbnServer.newPlatformthat exposes: