Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSVB doesn't work for percentile aggregation in Gauge, metric and Top N #31680

Merged
merged 2 commits into from
Feb 22, 2019

Conversation

alexwizp
Copy link
Contributor

Summary

Fix #31317

Before:
21_0

After:
21_1

Checklist

For maintainers

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@flash1293
Copy link
Contributor

Tested and works, but the table doesn't show anything for percentiles, is this expected?
screenshot 2019-02-22 at 10 31 24

@alexwizp
Copy link
Contributor Author

@flash1293 Hm... looks like the table view has more issues. I'll revert changes in response_processors/table/percentile.js. Table view will be fixed in scope of #16916

Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested and works as expected

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@alexwizp alexwizp merged commit 5672732 into elastic:master Feb 22, 2019
alexwizp added a commit to alexwizp/kibana that referenced this pull request Feb 22, 2019
alexwizp added a commit to alexwizp/kibana that referenced this pull request Feb 22, 2019
alexwizp added a commit to alexwizp/kibana that referenced this pull request Feb 22, 2019
@alexwizp alexwizp deleted the 31317 branch January 4, 2020 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants