Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use embeddable registry in add panel #31400

Merged

Conversation

flash1293
Copy link
Contributor

  • Use embeddable registry in add panel
  • Use EuiListGroup instead of table

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@flash1293 flash1293 force-pushed the 27985/feature-embeddable-layer-add-panel branch 2 times, most recently from 445b172 to 4d91ae4 Compare February 22, 2019 11:00
@flash1293 flash1293 force-pushed the 27985/feature-embeddable-layer-add-panel branch from d7a572f to 739deda Compare March 4, 2019 07:28
@flash1293 flash1293 changed the title [wip] [skip ci] Use embeddable registry in add panel [wip] Use embeddable registry in add panel Mar 4, 2019
@flash1293
Copy link
Contributor Author

Jenkins, test this.

@flash1293 flash1293 requested a review from a team as a code owner March 4, 2019 15:38
@flash1293 flash1293 force-pushed the 27985/feature-embeddable-layer-add-panel branch from e1f891f to 962cc49 Compare March 4, 2019 16:15
@elasticmachine
Copy link
Contributor

💔 Build Failed

@flash1293 flash1293 force-pushed the 27985/feature-embeddable-layer-add-panel branch from 962cc49 to 501f38a Compare March 4, 2019 16:31
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@flash1293 flash1293 changed the title [wip] Use embeddable registry in add panel Use embeddable registry in add panel Mar 6, 2019
@flash1293 flash1293 requested a review from timroes March 6, 2019 08:35
@timroes
Copy link
Contributor

timroes commented Mar 6, 2019

Another comment. I think the way the second part of the new wizard dialog used a bit more width was also nicer beforehand. But I am unfortunately able to figure out what's exactly causing the old dialog to have that higher width, since I don't see any min-width in there either. @cchaos do you have any idea how we could keep that behavior?

@flash1293 flash1293 requested a review from a team as a code owner March 6, 2019 14:11
@flash1293
Copy link
Contributor Author

This touched x-pack because I improved typings for UiRegistry which has to be updated in a few places.

@elasticmachine
Copy link
Contributor

💔 Build Failed

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 Fantastic! TY!

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@timroes timroes added release_note:enhancement Feature:Dashboard Dashboard related features Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 :AppArch v7.2.0 labels Mar 11, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retested UI, and those changes look awesome. Everything still seems to work.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@timroes
Copy link
Contributor

timroes commented Mar 11, 2019

Ignoring Security CODEOWNER review, since we only removed one @ts-ignore in a file owned by the security team.

@timroes timroes merged commit f935c14 into elastic:master Mar 11, 2019
timroes pushed a commit to timroes/kibana that referenced this pull request Mar 11, 2019
* Prepare control flow to use embeddable factories in add panel

* Rewrite saved object finder and add tests

* Fix usages of new saved object finder

* fix test failures

* fix some functional tests and re-introduce makeUrl

* fix tests

* remove direct hrefs in saved_object_lists

* PR review fixes

* update snapshot

* overwrite width of viz dialog

* Update src/legacy/core_plugins/kibana/public/dashboard/top_nav/add_panel.js

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/discover/embeddable/search_embeddable_factory.ts

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/discover/top_nav/open_search_panel.js

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/visualize/wizard/search_selection/search_selection.tsx

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/visualize/wizard/search_selection/search_selection.tsx

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/visualize/wizard/search_selection/search_selection.tsx

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* fix tests

* review fixes #1

* review fixes #2

* dont use classname in functional test

* remove call to action button prop

* align buttons correctly

* fix tests

* remove debugging statement

* Update src/legacy/core_plugins/kibana/public/dashboard/top_nav/add_panel.js

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/discover/top_nav/open_search_panel.js

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* review fixes #3

* improve filter behavior and enable it for search wizard

* adjust functional tests for new filter behavior

* Change translation id due to string change

* Update Jest snapshot
timroes added a commit that referenced this pull request Mar 11, 2019
* Prepare control flow to use embeddable factories in add panel

* Rewrite saved object finder and add tests

* Fix usages of new saved object finder

* fix test failures

* fix some functional tests and re-introduce makeUrl

* fix tests

* remove direct hrefs in saved_object_lists

* PR review fixes

* update snapshot

* overwrite width of viz dialog

* Update src/legacy/core_plugins/kibana/public/dashboard/top_nav/add_panel.js

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/discover/embeddable/search_embeddable_factory.ts

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/discover/top_nav/open_search_panel.js

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/visualize/wizard/search_selection/search_selection.tsx

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/visualize/wizard/search_selection/search_selection.tsx

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/visualize/wizard/search_selection/search_selection.tsx

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* fix tests

* review fixes #1

* review fixes #2

* dont use classname in functional test

* remove call to action button prop

* align buttons correctly

* fix tests

* remove debugging statement

* Update src/legacy/core_plugins/kibana/public/dashboard/top_nav/add_panel.js

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* Update src/legacy/core_plugins/kibana/public/discover/top_nav/open_search_panel.js

Co-Authored-By: flash1293 <email@johannes-reuter.de>

* review fixes #3

* improve filter behavior and enable it for search wizard

* adjust functional tests for new filter behavior

* Change translation id due to string change

* Update Jest snapshot
@nreese
Copy link
Contributor

nreese commented Mar 11, 2019

Question about sorting, How do you return to the original sort order (relevancy returned from elasticsearch) after applying sort?

Screen Shot 2019-03-11 at 8 49 51 AM

@timroes
Copy link
Contributor

timroes commented Mar 11, 2019

If you query for something, that "Sort" dialog should have a "Best match" option, that allows sorting by the order ES returned to you (and also should by default sort by best match. If you're not searching for anything that order is anyway "arbitrary" so if you're not searching by default we search ascending alphabetically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Dashboard Dashboard related features release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.2.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants