[CCR] Show CCR title even when the user is unauthorized. #27273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
added
Feature:CCR and Remote Clusters
Team:Kibana Management
Contributor
|
Pinging @elastic/es-ui |
Contributor
💚 Build Succeeded |
sebelga
approved these changes
Dec 18, 2018
Contributor
sebelga
left a comment
sebelga
left a comment
There was a problem hiding this comment.
Code LGTM! I haven't been able to test it in the browser as I don't know what Kibana user is needed to manage privileges.
Contributor
There was a problem hiding this comment.
Small nit: this could be simply written: {isAutoFollowApiAuthorized && ( ... without the ternary operator
cjcenizal
force-pushed
the
ccr/show-header-when-unauthorized
branch
from
a2811e5 to
a5786fc
Compare
Contributor
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the privileges required for a user to access both remote clusters and CCR:
If you log in as a user without those permissions (e.g. a user with only the
kibana_userrole), CCR will look like this:This PR displays the title to keep CCR consistent with RC and Rollup Jobs: