[6.x] Move buildEsQuery to a package #26306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: move buildEsQuery to utils * fix: tests that I broke * fix: add back link to the docs * fix: don't export from ui/ and link to utils * fix: move to a package * fix: move error to errors.js * fix: paths for peg task * fix: update reference to kuery * fix: build step for transpilation * fix: add typescript declaration file * fix: test * tmp: debug individual tests * debug: add debug stuff for reporting tests * try to debug test * Testing splitting reporting jobs in two * Testing splitting each job * Fix ci yaml * Skipping job to check failing test * debug - adding a catch to jobResponseHandler on report * Testing a different job and enabling verbose mode * Testing verbose on phantom_api skipping other CI tests * Fix script mode * fix: try running tests in chromium * fix: move out of devDependencies * fix: remove commented test * Revert "fix: try running tests in chromium" This reverts commit 991d46f. * Revert testing changes * Fixing build for phantomjs * Revert CI configuration to master. Remove verbose logging for tests
lukasolson
added
review
backport
Team:Visualizations
|
Pinging @elastic/kibana-app |
💚 Build Succeeded |
lukasolson
changed the title
💚 Build Succeeded |
💚 Build Succeeded |
|
will this be merged any time soon or should I work around it? |
|
@weltenwort Just waiting on reviews. @Bargs @markov00 do either of you have time to give this a look? Or do you have time @weltenwort? |
|
I'm a bit swamped with stuff that has a deadline attached, sorry... I can use the old imports in my PR for now if you expect this to take a while |
💚 Build Succeeded |
|
Going to try to get to this in the next couple days |
…ana into backport/es-query-package
💔 Build Failed |
💚 Build Succeeded |
Bargs
approved these changes
Dec 13, 2018
…ana into backport/es-query-package
💔 Build Failed |
|
Retest |
💚 Build Succeeded |
|
@weltenwort @sqren Did you want to check out this PR and ensure your usages are still working (in 6.x)? |
|
@lukasolson Sorry for not getting back to you before. I'll check this out tomorrow (Tuesday) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #23345 to 6.x.
This wasn't quite a clean backport because #15640 wasn't backported to 6.x, so we had to fix a couple of things manually.
The files that had to be manually fixed are the following:
Basically,
fromFiltersandfromLucenenow importdecorateQueryinstead of being passed it as an argument, and instead acceptconfigas an argument, which they pass down todecorateQuery.Since
buildOtherBucketAgghistorically sent a noop asdecorateQueryintofromFilters, it doesn't need to pass anyconfig, sodecorateQuerywas updated to check ifconfigis passed in, and only if it is, to decorate the query with the query string options from the config.