Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[babel-register] ignore packages directory when running from source #26098

Merged
merged 4 commits into from
Nov 23, 2018

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Nov 22, 2018

When running the Kibana distributable packages are excluded from babel-register because they are installed in the node_modules directory. When running from source they are not ignored, which means that babel-register is doing more work than necessary because these files need to already be built. To fix this I've added an ignore rule that excludes all packages when we are running from source.

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

@elastic elastic deleted a comment from elasticmachine Nov 22, 2018
@spalger spalger force-pushed the fix/babel-register-ignore-packages branch from 37fed60 to e485416 Compare November 22, 2018 23:00
@spalger spalger force-pushed the fix/babel-register-ignore-packages branch from e485416 to e02ed22 Compare November 22, 2018 23:02
@elastic elastic deleted a comment from elasticmachine Nov 23, 2018
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! Nice one @spalger

@spalger spalger merged commit 4b0893a into elastic:master Nov 23, 2018
spalger pushed a commit to spalger/kibana that referenced this pull request Nov 23, 2018
…lastic#26098)

When running the Kibana distributable packages are excluded from `babel-register` because they are installed in the node_modules directory. When running from source they are not ignored, which means that babel-register is doing more work than necessary because these files need to already be built. To fix this I've added an ignore rule that excludes all packages when we are running from source.
spalger pushed a commit to spalger/kibana that referenced this pull request Nov 23, 2018
…lastic#26098)

When running the Kibana distributable packages are excluded from `babel-register` because they are installed in the node_modules directory. When running from source they are not ignored, which means that babel-register is doing more work than necessary because these files need to already be built. To fix this I've added an ignore rule that excludes all packages when we are running from source.
spalger pushed a commit that referenced this pull request Nov 23, 2018
…urce (#26098) (#26102)

Backports the following commits to 6.x:
 - [babel-register] ignore packages directory when running from source  (#26098)
spalger pushed a commit that referenced this pull request Nov 23, 2018
…urce (#26098) (#26103)

Backports the following commits to 6.5:
 - [babel-register] ignore packages directory when running from source  (#26098)
@spalger
Copy link
Contributor Author

spalger commented Nov 23, 2018

6.6/6.x: 5071acf
6.5: 88948f3

@spalger spalger deleted the fix/babel-register-ignore-packages branch November 23, 2018 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants