[APM] Move style variables to commons #26089
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorenlouv
requested review from
ogupte and
jasonrhodes
and removed request for
ogupte
💚 Build Succeeded |
|
Took a different direction and not needed anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we want to access variables like
colorsfrom the backend,variables.tsneeds to be moved tocommonso it's accessible from both backend and frontend.Case in point
After refactoring the backend into "fetchers" and "transfomers" I think it makes sense to break up this huge file that does transformations to the chart data, and move it to the backend. We already have a bunch of transformations going on in the backend, and the process is currently overly complicated because we do it both backend and frontend.