[canvas/plugins] enable typescript support #26050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
Team:Operations
|
Pinging @elastic/kibana-operations |
|
Pinging @elastic/kibana-canvas |
|
LGTM... I'm going to patch it down and test it against my changes. |
|
I'm no typescript expert, but the changes here are minimal:
Seems fine to me as long as someone can validate it actually works. |
💔 Build Failed |
|
Works with my code: #26044 with no weird side effects. Thanks! |
clintandrewhall
approved these changes
Nov 21, 2018
…vas-plugin-ts-support
💚 Build Succeeded |
spalger
force-pushed
the
implement/canvas-plugin-ts-support
branch
from
5fab7c7
to
78ae637
Compare
spalger
force-pushed
the
implement/canvas-plugin-ts-support
branch
from
78ae637
to
be519f2
Compare
💚 Build Succeeded |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Nov 22, 2018
spalger
pushed a commit
that referenced
this pull request
Nov 22, 2018
|
6.x/6.6: 439e0a8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr just adds the ts-loader to the canvas plugins' webpack config to support ts there.