[pageObjects/visualize] use retry to avoid stale element references #25973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
Feature:Data Table
Contributor
|
Pinging @elastic/kibana-app |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…eordered in the first place
This comment has been minimized.
This comment has been minimized.
Contributor
💚 Build Succeeded |
Contributor
Author
|
retest |
Contributor
💚 Build Succeeded |
Contributor
Author
|
retest |
Contributor
💚 Build Succeeded |
Contributor
Author
|
retest |
timroes
approved these changes
Nov 21, 2018
Contributor
timroes
left a comment
timroes
left a comment
There was a problem hiding this comment.
Code LGTM, lets hope it fixes the behavior :)
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Nov 21, 2018
…lastic#25973) Fixes elastic#25892 This should address the flakiness observed in this issue by retrying if there is a stale element in the complex `PageObjects.visualize.filterOnTableCell()` method, and using `testSubjects.getVisibleText()` rather than calling `getVisibleText()` directly on the element without retrying.
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Nov 21, 2018
…lastic#25973) Fixes elastic#25892 This should address the flakiness observed in this issue by retrying if there is a stale element in the complex `PageObjects.visualize.filterOnTableCell()` method, and using `testSubjects.getVisibleText()` rather than calling `getVisibleText()` directly on the element without retrying.
spalger
pushed a commit
that referenced
this pull request
Nov 21, 2018
…25973) (#26017) Fixes #25892 This should address the flakiness observed in this issue by retrying if there is a stale element in the complex `PageObjects.visualize.filterOnTableCell()` method, and using `testSubjects.getVisibleText()` rather than calling `getVisibleText()` directly on the element without retrying.
Contributor
Author
spalger
pushed a commit
that referenced
this pull request
Nov 22, 2018
…25973) (#26018) Fixes #25892 This should address the flakiness observed in this issue by retrying if there is a stale element in the complex `PageObjects.visualize.filterOnTableCell()` method, and using `testSubjects.getVisibleText()` rather than calling `getVisibleText()` directly on the element without retrying.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25892
This should address the flakiness observed in this issue by retrying if there is a stale element in the complex
PageObjects.visualize.filterOnTableCell()method, and usingtestSubjects.getVisibleText()rather than callinggetVisibleText()directly on the element without retrying.