Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rollups] Improve Rollup Job Wizard error handling #25092

Merged
merged 8 commits into from
Nov 5, 2018
Merged

[Rollups] Improve Rollup Job Wizard error handling #25092

merged 8 commits into from
Nov 5, 2018

Commits on Nov 3, 2018

  1. Improve Rollup Job Wizard error handling. 

    - Consistently format errors with showApiWarning and showApiError helpers.
- Use fatalError for unexpected errors.
- Localize errors.
    @cjcenizal
    cjcenizal committed Nov 3, 2018
    Configuration menu
    Copy the full SHA
    b891a48 View commit details
    Browse the repository at this point in the history

  2. Surface error in Job List when the jobs can't be loaded.

    @cjcenizal
    cjcenizal committed Nov 3, 2018
    Configuration menu
    Copy the full SHA
    4ebf0b1 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary comment.

    @cjcenizal
    cjcenizal committed Nov 3, 2018
    Configuration menu
    Copy the full SHA
    cdb7b15 View commit details
    Browse the repository at this point in the history

  4. Localize index pattern validation fatal error location.

    @cjcenizal
    cjcenizal committed Nov 3, 2018
    Configuration menu
    Copy the full SHA
    d0fb9a1 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2018

  1. Address i18n feedback.

    @cjcenizal
    cjcenizal committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    803e8fb View commit details
    Browse the repository at this point in the history

  2. Don't return fatalError.

    @cjcenizal
    cjcenizal committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    afe1212 View commit details
    Browse the repository at this point in the history

  3. Identify origin of toasts in their titles.

    @cjcenizal
    cjcenizal committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    39770a5 View commit details
    Browse the repository at this point in the history

  4. Rename createToast to createToastConfig.

    @cjcenizal
    cjcenizal committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    2f759fb View commit details
    Browse the repository at this point in the history