Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[I18n] Translate Graph #23987

Merged
merged 9 commits into from
Nov 22, 2018
Merged

[I18n] Translate Graph #23987

merged 9 commits into from
Nov 22, 2018

Conversation

LeanidShutau
Copy link
Contributor

@LeanidShutau LeanidShutau added WIP Work in progress Project:i18n Feature:Graph Graph application feature labels Oct 12, 2018
@LeanidShutau LeanidShutau self-assigned this Oct 12, 2018
@LeanidShutau LeanidShutau changed the title [I18n] Add Graph translations [skip ci][wip][I18n] Add Graph translations Oct 12, 2018
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@LeanidShutau LeanidShutau force-pushed the feature/translations/graph branch 2 times, most recently from ef2093b to 2167a0f Compare October 16, 2018 16:22
@LeanidShutau LeanidShutau added Feature:Graph Graph application feature and removed Feature:Graph Graph application feature labels Oct 18, 2018
@LeanidShutau LeanidShutau removed their assignment Oct 18, 2018
@LeanidShutau LeanidShutau changed the title [skip ci][wip][I18n] Add Graph translations [I18n] Add Graph translations Oct 30, 2018
@LeanidShutau
Copy link
Contributor Author

retest

@LeanidShutau LeanidShutau removed the WIP Work in progress label Oct 30, 2018
@LeanidShutau LeanidShutau self-assigned this Oct 30, 2018
@elastic elastic deleted a comment from elasticmachine Oct 30, 2018
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@pavel06081991 pavel06081991 removed the request for review from maryia-lapata October 31, 2018 08:13
pavel06081991
pavel06081991 reviewed Oct 31, 2018
View reviewed changes
Copy link
Contributor

@pavel06081991 pavel06081991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good. Please fix some small comments

x-pack/plugins/graph/public/app.js Show resolved Hide resolved
x-pack/plugins/graph/public/app.js Show resolved Hide resolved
x-pack/plugins/graph/public/app.js Show resolved Hide resolved
x-pack/plugins/graph/public/app.js Show resolved Hide resolved
x-pack/plugins/graph/public/app.js Show resolved Hide resolved
x-pack/plugins/graph/public/templates/settings.html Outdated Show resolved Hide resolved
x-pack/plugins/graph/public/templates/settings.html Outdated Show resolved Hide resolved
x-pack/plugins/graph/public/templates/settings.html Outdated Show resolved Hide resolved
x-pack/plugins/graph/public/templates/settings.html Outdated Show resolved Hide resolved
x-pack/plugins/graph/public/services/outlink_encoders.js Show resolved Hide resolved
@elastic elastic deleted a comment from elasticmachine Nov 1, 2018
@LeanidShutau
Copy link
Contributor Author

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@timroes timroes added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Nov 12, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@LeanidShutau LeanidShutau requested review from azasypkin and removed request for timroes November 13, 2018 09:59
@LeanidShutau LeanidShutau added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Nov 13, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@LeanidShutau LeanidShutau changed the title [I18n] Add Graph translations [I18n] Translate Graph Nov 13, 2018
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@azasypkin azasypkin removed the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Nov 13, 2018
spalger
spalger approved these changes Nov 21, 2018
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny nit, seems to work great!

x-pack/plugins/graph/public/app.js Outdated Show resolved Hide resolved
@LeanidShutau LeanidShutau removed the request for review from azasypkin November 22, 2018 07:09
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@LeanidShutau LeanidShutau merged commit 43d4c22 into elastic:master Nov 22, 2018
@LeanidShutau LeanidShutau deleted the feature/translations/graph branch November 22, 2018 10:41
@LeanidShutau LeanidShutau mentioned this pull request Nov 22, 2018
Merged
LeanidShutau added a commit to LeanidShutau/kibana that referenced this pull request Nov 22, 2018
@LeanidShutau
[I18n] Translate Graph (elastic#23987)
d7b330e 
* [I18n] Add Graph translations

* Fix typo

* Use template strings
LeanidShutau added a commit that referenced this pull request Nov 22, 2018
@LeanidShutau
[I18n] Translate Graph (#23987) (#26090)
f19323d 
* [I18n] Add Graph translations

* Fix typo

* Use template strings
@LeanidShutau
Copy link
Contributor Author

6.x/6.6: f19323d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalger spalger spalger approved these changes

@pavel06081991 pavel06081991 pavel06081991 approved these changes

Assignees

@LeanidShutau LeanidShutau

Labels
backported Feature:Graph Graph application feature Project:i18n Team:Visualizations Visualization editors, elastic-charts and infrastructure v6.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@LeanidShutau @elasticmachine @spalger @pavel06081991 @timroes @azasypkin @maryia-lapata