Add support to deprecate connector types

src/platform/packages/shared/kbn-actions-types/action_types.ts

@@ -24,4 +24,5 @@ export interface ActionType {
   supportedFeatureIds: string[];
   isSystemActionType: boolean;
   subFeature?: SubFeature;
+  isDeprecated: boolean;
 }

src/platform/packages/shared/kbn-alerts-ui-shared/src/check_action_type_enabled/check_action_type_enabled.test.ts

@@ -33,6 +33,7 @@ describe('checkActionTypeEnabled', () => {
       enabledInConfig: true,
       enabledInLicense: true,
       isSystemActionType: false,
+      isDeprecated: false,
     };
     expect(checkActionTypeEnabled(actionType)).toMatchInlineSnapshot(`
           Object {
@@ -51,6 +52,7 @@ describe('checkActionTypeEnabled', () => {
       enabledInConfig: true,
       enabledInLicense: false,
       isSystemActionType: false,
+      isDeprecated: false,
     };
     expect(checkActionTypeEnabled(actionType)).toMatchInlineSnapshot(`
       Object {
@@ -86,6 +88,7 @@ describe('checkActionTypeEnabled', () => {
       enabledInConfig: false,
       enabledInLicense: true,
       isSystemActionType: false,
+      isDeprecated: false,
     };
     expect(checkActionTypeEnabled(actionType)).toMatchInlineSnapshot(`
           Object {
@@ -109,6 +112,7 @@ describe('checkActionTypeEnabled', () => {
       enabledInConfig: false,
       enabledInLicense: true,
       isSystemActionType: false,
+      isDeprecated: false,
     };
 
     const isPreconfiguredConnector = true;
@@ -131,6 +135,7 @@ describe('checkActionFormActionTypeEnabled', () => {
       isDeprecated: true,
       name: 'test',
       referencedByCount: 0,
+      isConnectorTypeDeprecated: false,
     },
     {
       actionTypeId: '2',
@@ -140,6 +145,7 @@ describe('checkActionFormActionTypeEnabled', () => {
       isSystemAction: false,
       name: 'test',
       referencedByCount: 0,
+      isConnectorTypeDeprecated: false,
     },
   ];
 
@@ -153,6 +159,7 @@ describe('checkActionFormActionTypeEnabled', () => {
       enabledInConfig: false,
       enabledInLicense: true,
       isSystemActionType: false,
+      isDeprecated: false,
     };
 
     expect(checkActionFormActionTypeEnabled(actionType, preconfiguredConnectors))
@@ -173,6 +180,7 @@ describe('checkActionFormActionTypeEnabled', () => {
       enabledInConfig: false,
       enabledInLicense: true,
       isSystemActionType: false,
+      isDeprecated: false,
     };
     expect(checkActionFormActionTypeEnabled(actionType, preconfiguredConnectors))
       .toMatchInlineSnapshot(`

src/platform/packages/shared/kbn-alerts-ui-shared/src/common/apis/fetch_connector_types/fetch_connector_types.test.ts

@@ -27,6 +27,7 @@ describe('loadActionTypes', () => {
         supported_feature_ids: ['alerting'],
         minimum_license_required: 'basic',
         is_system_action_type: false,
+        is_deprecated: false,
       },
     ];
     http.get.mockResolvedValueOnce(apiResponseValue);
@@ -41,6 +42,7 @@ describe('loadActionTypes', () => {
         supportedFeatureIds: ['alerting'],
         minimumLicenseRequired: 'basic',
         isSystemActionType: false,
+        isDeprecated: false,
       },
     ];
 
@@ -65,6 +67,7 @@ describe('loadActionTypes', () => {
         supported_feature_ids: ['alerting'],
         minimum_license_required: 'basic',
         is_system_action_type: false,
+        is_deprecated: false,
       },
     ];
     http.get.mockResolvedValueOnce(apiResponseValue);
@@ -79,6 +82,7 @@ describe('loadActionTypes', () => {
         supportedFeatureIds: ['alerting'],
         minimumLicenseRequired: 'basic',
         isSystemActionType: false,
+        isDeprecated: false,
       },
     ];
 
@@ -107,6 +111,7 @@ describe('loadActionTypes', () => {
         supported_feature_ids: ['alerting'],
         minimum_license_required: 'basic',
         is_system_action_type: true,
+        is_deprecated: false,
       },
       {
         id: 'test',
@@ -117,6 +122,7 @@ describe('loadActionTypes', () => {
         supported_feature_ids: ['alerting'],
         minimum_license_required: 'basic',
         is_system_action_type: false,
+        is_deprecated: false,
       },
     ];
 
@@ -132,6 +138,7 @@ describe('loadActionTypes', () => {
         supportedFeatureIds: ['alerting'],
         minimumLicenseRequired: 'basic',
         isSystemActionType: true,
+        isDeprecated: false,
       },
       {
         id: 'test',
@@ -142,6 +149,7 @@ describe('loadActionTypes', () => {
         supportedFeatureIds: ['alerting'],
         minimumLicenseRequired: 'basic',
         isSystemActionType: false,
+        isDeprecated: false,
       },
     ];
 
@@ -166,6 +174,7 @@ describe('loadActionTypes', () => {
         supported_feature_ids: ['alerting'],
         minimum_license_required: 'basic',
         is_system_action_type: true,
+        is_deprecated: false,
       },
       {
         id: 'test',
@@ -176,6 +185,7 @@ describe('loadActionTypes', () => {
         supported_feature_ids: ['alerting'],
         minimum_license_required: 'basic',
         is_system_action_type: false,
+        is_deprecated: false,
       },
     ];
 
@@ -191,6 +201,7 @@ describe('loadActionTypes', () => {
         supportedFeatureIds: ['alerting'],
         minimumLicenseRequired: 'basic',
         isSystemActionType: true,
+        isDeprecated: false,
       },
       {
         id: 'test',
@@ -201,6 +212,7 @@ describe('loadActionTypes', () => {
         supportedFeatureIds: ['alerting'],
         minimumLicenseRequired: 'basic',
         isSystemActionType: false,
+        isDeprecated: false,
       },
     ];
 

src/platform/packages/shared/kbn-alerts-ui-shared/src/common/apis/fetch_connector_types/transform_connector_types_response.test.ts

@@ -22,6 +22,7 @@ describe('transformConnectorTypesResponse', () => {
         supported_feature_ids: ['stackAlerts'],
         is_system_action_type: true,
         sub_feature: 'endpointSecurity',
+        is_deprecated: false,
       },
       {
         id: 'actionType2Id',
@@ -32,6 +33,7 @@ describe('transformConnectorTypesResponse', () => {
         minimum_license_required: 'basic',
         supported_feature_ids: ['stackAlerts'],
         is_system_action_type: false,
+        is_deprecated: false,
       },
     ]);
 
@@ -46,6 +48,7 @@ describe('transformConnectorTypesResponse', () => {
         supportedFeatureIds: ['stackAlerts'],
         isSystemActionType: true,
         subFeature: 'endpointSecurity',
+        isDeprecated: false,
       },
       {
         id: 'actionType2Id',
@@ -56,6 +59,7 @@ describe('transformConnectorTypesResponse', () => {
         minimumLicenseRequired: 'basic',
         supportedFeatureIds: ['stackAlerts'],
         isSystemActionType: false,
+        isDeprecated: false,
       },
     ]);
   });

src/platform/packages/shared/kbn-alerts-ui-shared/src/common/apis/fetch_connector_types/transform_connector_types_response.ts

@@ -16,6 +16,7 @@ const transformConnectorType: RewriteRequestCase<ActionType> = ({
   supported_feature_ids: supportedFeatureIds,
   is_system_action_type: isSystemActionType,
   sub_feature: subFeature,
+  is_deprecated: isDeprecated,
   ...res
 }: AsApiContract<ActionType>) => ({
   enabledInConfig,
@@ -24,6 +25,7 @@ const transformConnectorType: RewriteRequestCase<ActionType> = ({
   supportedFeatureIds,
   isSystemActionType,
   subFeature,
+  isDeprecated,
   ...res,
 });
 

src/platform/packages/shared/kbn-alerts-ui-shared/src/common/apis/fetch_connectors/fetch_connectors.test.ts

@@ -8,8 +8,9 @@
  */
 
 import { httpServiceMock } from '@kbn/core/public/mocks';
-import type { ActionConnectorProps } from '../../types';
+import type { ActionConnector } from '../../types';
 import { fetchConnectors } from './fetch_connectors';
+import { createMockActionConnector } from '../../test_utils/connector.mock';
 
 const http = httpServiceMock.createStartContract();
 
@@ -27,24 +28,22 @@ describe('fetchConnectors', () => {
         is_missing_secrets: false,
         is_system_action: false,
         referenced_by_count: 0,
+        is_connector_type_deprecated: false,
         secrets: {},
         config: {},
       },
     ];
 
-    const resolvedValue: Array<ActionConnectorProps<{}, {}>> = [
-      {
+    const resolvedValue: Array<ActionConnector<{}, {}>> = [
+      createMockActionConnector({
         id: 'test-connector',
         name: 'Test',
         actionTypeId: 'test',
-        isPreconfigured: false,
-        isDeprecated: false,
-        isMissingSecrets: false,
-        isSystemAction: false,
         referencedByCount: 0,
+        isMissingSecrets: false,
         secrets: {},
         config: {},
-      },
+      }),
     ];
 
     http.get.mockResolvedValueOnce(apiResponseValue);
@@ -70,13 +69,12 @@ describe('fetchConnectors', () => {
         is_missing_secrets: false,
         is_system_action: true,
         referenced_by_count: 0,
-        secrets: {},
-        config: {},
+        is_connector_type_deprecated: false,
       },
     ];
 
-    const resolvedValue: Array<ActionConnectorProps<{}, {}>> = [
-      {
+    const resolvedValue: Array<ActionConnector<{}, {}>> = [
+      createMockActionConnector({
         id: '.test-system-action',
         name: 'System action name',
         actionTypeId: 'test',
@@ -85,9 +83,8 @@ describe('fetchConnectors', () => {
         isMissingSecrets: false,
         isSystemAction: true,
         referencedByCount: 0,
-        secrets: {},
-        config: {},
-      },
+        isConnectorTypeDeprecated: false,
+      }),
     ];
 
     http.get.mockResolvedValueOnce(apiResponseValue);

src/platform/packages/shared/kbn-alerts-ui-shared/src/common/apis/fetch_connectors/transform_connectors_response.test.ts

@@ -23,6 +23,7 @@ describe('transformConnectorsResponse', () => {
         referenced_by_count: 0,
         secrets: {},
         config: {},
+        is_connector_type_deprecated: false,
       },
       {
         id: 'test-connector-2',
@@ -35,6 +36,7 @@ describe('transformConnectorsResponse', () => {
         referenced_by_count: 0,
         secrets: {},
         config: {},
+        is_connector_type_deprecated: true,
       },
     ]);
 
@@ -50,6 +52,7 @@ describe('transformConnectorsResponse', () => {
         name: 'Test-1',
         referencedByCount: 0,
         secrets: {},
+        isConnectorTypeDeprecated: false,
       },
       {
         actionTypeId: 'test-2',
@@ -62,6 +65,7 @@ describe('transformConnectorsResponse', () => {
         name: 'Test-2',
         referencedByCount: 0,
         secrets: {},
+        isConnectorTypeDeprecated: true,
       },
     ]);
   });

src/platform/packages/shared/kbn-alerts-ui-shared/src/common/apis/fetch_connectors/transform_connectors_response.ts

@@ -27,6 +27,7 @@ const transformConnector: RewriteRequestCase<
   referenced_by_count: referencedByCount,
   is_missing_secrets: isMissingSecrets,
   is_system_action: isSystemAction,
+  is_connector_type_deprecated: isConnectorTypeDeprecated,
   ...res
 }) => ({
   actionTypeId,
@@ -35,5 +36,6 @@ const transformConnector: RewriteRequestCase<
   referencedByCount,
   isMissingSecrets,
   isSystemAction,
+  isConnectorTypeDeprecated,
   ...res,
 });