Skip to content

[AI Infra] Update logic for getConnectorById #229227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

qn895
Copy link
Member

@qn895 qn895 commented Jul 23, 2025

Summary

This PR updates logic for how connector is fetched: to not throw error if system action. In doing so, this also clarifies at which stage an error happens. I.e. if there's a problem with fetching the connectors, if the connector does not exist, or if the action type is incompatible.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@qn895 qn895 requested a review from a team as a code owner July 23, 2025 22:02
@qn895 qn895 self-assigned this Jul 23, 2025
@qn895 qn895 added :ml release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels Team:AI Infra AppEx AI Infrastructure Team labels Jul 23, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-ai-infra (Team:AI Infra)

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@qn895 qn895 added bug Fixes for quality problems that affect the customer experience release_note:fix v9.1.0 v8.19.0 v9.2.0 v9.0.5 v9.1.1 v8.18.5 and removed release_note:skip Skip the PR/issue when compiling release notes labels Jul 23, 2025
id: connectorId,
throwIfSystemAction: true,
});
connectors = await actionsClient.getAll();
Copy link
Contributor

@pgayvallet pgayvallet Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I lack context on what we're trying to address here, but fetching all connectors when we only need to access one feels wrong to me?

@elasticmachine
Copy link
Contributor

elasticmachine commented Aug 12, 2025

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #53 / Actions and Triggers app Connectors General connector functionality should test a connector and display a failure result
  • [job] [logs] AppEx AI-Infra Inference APIs FTR tests / Inference plugin - API integration tests Connector azure-gpt4 chatComplete API streaming disabled returns an error with the expected shape in case of error
  • [job] [logs] AppEx AI-Infra Inference APIs FTR tests / Inference plugin - API integration tests Connector azure-gpt4 chatComplete API streaming disabled returns an error with the expected shape in case of error

Metrics [docs]

✅ unchanged

History

cc @qn895

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels bug Fixes for quality problems that affect the customer experience :ml release_note:fix Team:AI Infra AppEx AI Infrastructure Team v8.18.5 v8.19.0 v9.0.5 v9.1.0 v9.1.1 v9.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants