-
Notifications
You must be signed in to change notification settings - Fork 8.4k
[AI Infra] Update logic for getConnectorById #229227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
qn895
wants to merge
6
commits into
elastic:main
Choose a base branch
from
qn895:ai-connector-by-id-system
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/appex-ai-infra (Team:AI Infra) |
Pinging @elastic/ml-ui (:ml) |
pgayvallet
reviewed
Jul 24, 2025
id: connectorId, | ||
throwIfSystemAction: true, | ||
}); | ||
connectors = await actionsClient.getAll(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I lack context on what we're trying to address here, but fetching all connectors when we only need to access one feels wrong to me?
💔 Build Failed
Failed CI Steps
Test Failures
Metrics [docs]
History
cc @qn895 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:version
Backport to applied version labels
bug
Fixes for quality problems that affect the customer experience
:ml
release_note:fix
Team:AI Infra
AppEx AI Infrastructure Team
v8.18.5
v8.19.0
v9.0.5
v9.1.0
v9.1.1
v9.2.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates logic for how connector is fetched: to not throw error if system action. In doing so, this also clarifies at which stage an error happens. I.e. if there's a problem with fetching the connectors, if the connector does not exist, or if the action type is incompatible.
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breaking
label should be applied in these situations.release_note:*
label is applied per the guidelinesbackport:*
labels.Identify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.