[Obs AI Assistant] Fix re-deploy model timeout and status polling #220445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viduni94
added
release_note:skip
|
Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant) |
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
sorenlouv
reviewed
May 8, 2025
x-pack/platform/plugins/shared/observability_ai_assistant/server/service/client/index.ts
Outdated
Show resolved
Hide resolved
sorenlouv
reviewed
May 8, 2025
| @@ -84,7 +84,7 @@ const warmupModelKnowledgeBase = createObservabilityAIAssistantServerRoute({ | |||
| requiredPrivileges: ['ai_assistant'], | |||
| }, | |||
| }, | |||
| handler: async (resources): Promise<void> => { | |||
| handler: async (resources): Promise<{ currentInferenceId: string }> => { | |||
There was a problem hiding this comment.
currentInferenceId will always be the same as inferenceId, right? What's the use case for returning this to the client?
There was a problem hiding this comment.
@sorenlouv yes, we don't need to return it back. I updated it to just return instead of returning the inferenceId
6ed092f
sorenlouv
approved these changes
May 8, 2025
viduni94
force-pushed
the
fix-reploy-model-timeout-and-status-polling
branch
from
bdf985b to
082fbcb
Compare
⏳ Build in-progress
Failed CI StepsHistory
cc @viduni94 |
|
Starting backport for target branches: 8.19 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 8, 2025
…astic#220445) Closes elastic/obs-ai-assistant-team#247 Closes elastic#217912 ## Summary ### Problems - The `/warmup_model` endpoint doesn't return immediately and waits for the KB to be ready. If there is no ML nodes or sufficient capacity in the ML node, the API can timeout. - Since the endpoint doesn't return immediately, we don't poll for status continuously. - Knowledge base tab doesn't show `Inspect` if no ML nodes are available. ### Solutions - Show `Inspect` information in the knowledge base - Return `/warmup_model` immediately (we don't need to wait for the model to be ready since we are polling), and start polling - If the user refreshes the browser and if the `kbState` is in `DEPLOYING_MODEL` keep polling for status ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit ff3822d)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 8, 2025
…ing (#220445) (#220591) # Backport This will backport the following commits from `main` to `8.19`: - [[Obs AI Assistant] Fix re-deploy model timeout and status polling (#220445)](#220445) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Viduni Wickramarachchi","email":"viduni.wickramarachchi@elastic.co"},"sourceCommit":{"committedDate":"2025-05-08T21:49:20Z","message":"[Obs AI Assistant] Fix re-deploy model timeout and status polling (#220445)\n\nCloses https://github.com/elastic/obs-ai-assistant-team/issues/247\nCloses https://github.com/elastic/kibana/issues/217912\n\n## Summary\n\n### Problems\n- The `/warmup_model` endpoint doesn't return immediately and waits for\nthe KB to be ready. If there is no ML nodes or sufficient capacity in\nthe ML node, the API can timeout.\n- Since the endpoint doesn't return immediately, we don't poll for\nstatus continuously.\n- Knowledge base tab doesn't show `Inspect` if no ML nodes are\navailable.\n\n### Solutions\n\n- Show `Inspect` information in the knowledge base\n- Return `/warmup_model` immediately (we don't need to wait for the\nmodel to be ready since we are polling), and start polling\n- If the user refreshes the browser and if the `kbState` is in\n`DEPLOYING_MODEL` keep polling for status\n\n### Checklist\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"ff3822d0a34f7d2c9ac00953b9d198be2661f717","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Obs AI Assistant","ci:project-deploy-observability","backport:version","v9.1.0","v8.19.0"],"title":"[Obs AI Assistant] Fix re-deploy model timeout and status polling","number":220445,"url":"https://github.com/elastic/kibana/pull/220445","mergeCommit":{"message":"[Obs AI Assistant] Fix re-deploy model timeout and status polling (#220445)\n\nCloses https://github.com/elastic/obs-ai-assistant-team/issues/247\nCloses https://github.com/elastic/kibana/issues/217912\n\n## Summary\n\n### Problems\n- The `/warmup_model` endpoint doesn't return immediately and waits for\nthe KB to be ready. If there is no ML nodes or sufficient capacity in\nthe ML node, the API can timeout.\n- Since the endpoint doesn't return immediately, we don't poll for\nstatus continuously.\n- Knowledge base tab doesn't show `Inspect` if no ML nodes are\navailable.\n\n### Solutions\n\n- Show `Inspect` information in the knowledge base\n- Return `/warmup_model` immediately (we don't need to wait for the\nmodel to be ready since we are polling), and start polling\n- If the user refreshes the browser and if the `kbState` is in\n`DEPLOYING_MODEL` keep polling for status\n\n### Checklist\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"ff3822d0a34f7d2c9ac00953b9d198be2661f717"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/220445","number":220445,"mergeCommit":{"message":"[Obs AI Assistant] Fix re-deploy model timeout and status polling (#220445)\n\nCloses https://github.com/elastic/obs-ai-assistant-team/issues/247\nCloses https://github.com/elastic/kibana/issues/217912\n\n## Summary\n\n### Problems\n- The `/warmup_model` endpoint doesn't return immediately and waits for\nthe KB to be ready. If there is no ML nodes or sufficient capacity in\nthe ML node, the API can timeout.\n- Since the endpoint doesn't return immediately, we don't poll for\nstatus continuously.\n- Knowledge base tab doesn't show `Inspect` if no ML nodes are\navailable.\n\n### Solutions\n\n- Show `Inspect` information in the knowledge base\n- Return `/warmup_model` immediately (we don't need to wait for the\nmodel to be ready since we are polling), and start polling\n- If the user refreshes the browser and if the `kbState` is in\n`DEPLOYING_MODEL` keep polling for status\n\n### Checklist\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"ff3822d0a34f7d2c9ac00953b9d198be2661f717"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Viduni Wickramarachchi <viduni.wickramarachchi@elastic.co>
kdelemme
pushed a commit
to kdelemme/kibana
that referenced
this pull request
May 9, 2025
…astic#220445) Closes elastic/obs-ai-assistant-team#247 Closes elastic#217912 ## Summary ### Problems - The `/warmup_model` endpoint doesn't return immediately and waits for the KB to be ready. If there is no ML nodes or sufficient capacity in the ML node, the API can timeout. - Since the endpoint doesn't return immediately, we don't poll for status continuously. - Knowledge base tab doesn't show `Inspect` if no ML nodes are available. ### Solutions - Show `Inspect` information in the knowledge base - Return `/warmup_model` immediately (we don't need to wait for the model to be ready since we are polling), and start polling - If the user refreshes the browser and if the `kbState` is in `DEPLOYING_MODEL` keep polling for status ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
…astic#220445) Closes elastic/obs-ai-assistant-team#247 Closes elastic#217912 ## Summary ### Problems - The `/warmup_model` endpoint doesn't return immediately and waits for the KB to be ready. If there is no ML nodes or sufficient capacity in the ML node, the API can timeout. - Since the endpoint doesn't return immediately, we don't poll for status continuously. - Knowledge base tab doesn't show `Inspect` if no ML nodes are available. ### Solutions - Show `Inspect` information in the knowledge base - Return `/warmup_model` immediately (we don't need to wait for the model to be ready since we are polling), and start polling - If the user refreshes the browser and if the `kbState` is in `DEPLOYING_MODEL` keep polling for status ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
qn895
pushed a commit
to qn895/kibana
that referenced
this pull request
Jun 3, 2025
…astic#220445) Closes elastic/obs-ai-assistant-team#247 Closes elastic#217912 ## Summary ### Problems - The `/warmup_model` endpoint doesn't return immediately and waits for the KB to be ready. If there is no ML nodes or sufficient capacity in the ML node, the API can timeout. - Since the endpoint doesn't return immediately, we don't poll for status continuously. - Knowledge base tab doesn't show `Inspect` if no ML nodes are available. ### Solutions - Show `Inspect` information in the knowledge base - Return `/warmup_model` immediately (we don't need to wait for the model to be ready since we are polling), and start polling - If the user refreshes the browser and if the `kbState` is in `DEPLOYING_MODEL` keep polling for status ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/elastic/obs-ai-assistant-team/issues/247
Closes #217912
Summary
Problems
/warmup_modelendpoint doesn't return immediately and waits for the KB to be ready. If there is no ML nodes or sufficient capacity in the ML node, the API can timeout.Inspectif no ML nodes are available.Solutions
Inspectinformation in the knowledge base/warmup_modelimmediately (we don't need to wait for the model to be ready since we are polling), and start pollingkbStateis inDEPLOYING_MODELkeep polling for statusChecklist
release_note:*label is applied per the guidelines