Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SKA: Unify kbn-management folders + storybook config #211564

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

gsoldevila
Copy link
Contributor

@gsoldevila gsoldevila commented Feb 18, 2025

Summary

As part of the SKA, some groups of modules have been broken-down and relocated in different folders, negatively impacting DX. This is the case for kbn-management modules, that are spread across:

- packages/kbn-management (storybook config)
- src/platform/packages/private/kbn-management
- src/platform/packages/shared/kbn-management

The goal of this PR is to unify them back under src/platform/packages/shared/kbn-management.
In this scenario, I believe the simplification is worth the trade off.

CC @elastic/kibana-management WDYT?

@gsoldevila gsoldevila added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels v8.19.0 labels Feb 18, 2025
@gsoldevila gsoldevila requested review from a team as code owners February 18, 2025 12:30
Copy link
Contributor

@ElenaStoeva ElenaStoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kibana Management changes lgtm, but I'm deferring approval to @mattkime since he primarily worked on moving the team's modules for the Sustainable Kibana Architecture project and I'm not familiar with the reasoning behind why some of the packages were moved to the private directory while others were placed in shared.

@ElenaStoeva ElenaStoeva requested a review from mattkime February 18, 2025 16:26
Copy link
Contributor

@mattkime mattkime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #35 / Space awareness change space agent policies PUT /agent_policies/{id} should allow set policy in multiple space

Metrics [docs]

✅ unchanged

@gsoldevila
Copy link
Contributor Author

Kibana Management changes lgtm, but I'm deferring approval to @mattkime since he primarily worked on moving the team's modules for the Sustainable Kibana Architecture project and I'm not familiar with the reasoning behind why some of the packages were moved to the private directory while others were placed in shared.

I can answer this one. The visibility property applies to all packages in the "platform" group.
Packages can be:

  • "private": only accessible from within platform group.
  • "shared": accessible from solutions.

They were automatically categorised as private because they were not being imported / used from any solution.
In this case, we had storybook configs that were left dangling in the /packages folder, and some of the packages were already shared, so I think it's worth grouping them back, even if that means "sharing" some of them even though they're currently not accessed by solutions.

@gsoldevila gsoldevila merged commit b2b3fa9 into elastic:main Feb 19, 2025
10 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/13408047231

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 211564

Questions ?

Please refer to the Backport tool documentation

gsoldevila added a commit to gsoldevila/kibana that referenced this pull request Feb 19, 2025
## Summary

As part of the SKA, some groups of modules have been broken-down and
relocated in different folders, negatively impacting DX. This is the
case for `kbn-management` modules, that are spread across:
```
- packages/kbn-management (storybook config)
- src/platform/packages/private/kbn-management
- src/platform/packages/shared/kbn-management
```

The goal of this PR is to unify them back under
`src/platform/packages/shared/kbn-management`.
In this scenario, I believe the simplification is worth the trade off.

CC @elastic/kibana-management WDYT?

Co-authored-by: Matthew Kime <matt@mattki.me>
(cherry picked from commit b2b3fa9)

# Conflicts:
#	src/dev/storybook/aliases.ts
gsoldevila added a commit to gsoldevila/kibana that referenced this pull request Feb 19, 2025
## Summary

As part of the SKA, some groups of modules have been broken-down and
relocated in different folders, negatively impacting DX. This is the
case for `kbn-management` modules, that are spread across:
```
- packages/kbn-management (storybook config)
- src/platform/packages/private/kbn-management
- src/platform/packages/shared/kbn-management
```

The goal of this PR is to unify them back under
`src/platform/packages/shared/kbn-management`.
In this scenario, I believe the simplification is worth the trade off.

CC @elastic/kibana-management WDYT?

Co-authored-by: Matthew Kime <matt@mattki.me>
(cherry picked from commit b2b3fa9)

# Conflicts:
#	.github/CODEOWNERS
#	src/dev/storybook/aliases.ts
gsoldevila added a commit to gsoldevila/kibana that referenced this pull request Feb 19, 2025
## Summary

As part of the SKA, some groups of modules have been broken-down and
relocated in different folders, negatively impacting DX. This is the
case for `kbn-management` modules, that are spread across:
```
- packages/kbn-management (storybook config)
- src/platform/packages/private/kbn-management
- src/platform/packages/shared/kbn-management
```

The goal of this PR is to unify them back under
`src/platform/packages/shared/kbn-management`.
In this scenario, I believe the simplification is worth the trade off.

CC @elastic/kibana-management WDYT?

Co-authored-by: Matthew Kime <matt@mattki.me>
(cherry picked from commit b2b3fa9)

# Conflicts:
#	.github/CODEOWNERS
#	src/dev/storybook/aliases.ts
@gsoldevila
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
9.0
8.x
8.18

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

gsoldevila added a commit that referenced this pull request Feb 19, 2025
#211688)

# Backport

This will backport the following commits from `main` to `9.0`:
- [SKA: Unify &#x60;kbn-management&#x60; folders + storybook config
(#211564)](#211564)

<!--- Backport version: 9.6.4 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Gerard
Soldevila","email":"gerard.soldevila@elastic.co"},"sourceCommit":{"committedDate":"2025-02-19T08:10:22Z","message":"SKA:
Unify `kbn-management` folders + storybook config (#211564)\n\n##
Summary\r\n\r\nAs part of the SKA, some groups of modules have been
broken-down and\r\nrelocated in different folders, negatively impacting
DX. This is the\r\ncase for `kbn-management` modules, that are spread
across:\r\n```\r\n- packages/kbn-management (storybook config)\r\n-
src/platform/packages/private/kbn-management\r\n-
src/platform/packages/shared/kbn-management\r\n```\r\n\r\nThe goal of
this PR is to unify them back
under\r\n`src/platform/packages/shared/kbn-management`.\r\nIn this
scenario, I believe the simplification is worth the trade off.\r\n\r\nCC
@elastic/kibana-management WDYT?\r\n\r\nCo-authored-by: Matthew Kime
<matt@mattki.me>","sha":"b2b3fa9a84034bf6a49a38ea3b434245582c7909","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Kibana
Management","release_note:skip","v9.0.0","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"SKA:
Unify `kbn-management` folders + storybook
config","number":211564,"url":"https://github.com/elastic/kibana/pull/211564","mergeCommit":{"message":"SKA:
Unify `kbn-management` folders + storybook config (#211564)\n\n##
Summary\r\n\r\nAs part of the SKA, some groups of modules have been
broken-down and\r\nrelocated in different folders, negatively impacting
DX. This is the\r\ncase for `kbn-management` modules, that are spread
across:\r\n```\r\n- packages/kbn-management (storybook config)\r\n-
src/platform/packages/private/kbn-management\r\n-
src/platform/packages/shared/kbn-management\r\n```\r\n\r\nThe goal of
this PR is to unify them back
under\r\n`src/platform/packages/shared/kbn-management`.\r\nIn this
scenario, I believe the simplification is worth the trade off.\r\n\r\nCC
@elastic/kibana-management WDYT?\r\n\r\nCo-authored-by: Matthew Kime
<matt@mattki.me>","sha":"b2b3fa9a84034bf6a49a38ea3b434245582c7909"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/211564","number":211564,"mergeCommit":{"message":"SKA:
Unify `kbn-management` folders + storybook config (#211564)\n\n##
Summary\r\n\r\nAs part of the SKA, some groups of modules have been
broken-down and\r\nrelocated in different folders, negatively impacting
DX. This is the\r\ncase for `kbn-management` modules, that are spread
across:\r\n```\r\n- packages/kbn-management (storybook config)\r\n-
src/platform/packages/private/kbn-management\r\n-
src/platform/packages/shared/kbn-management\r\n```\r\n\r\nThe goal of
this PR is to unify them back
under\r\n`src/platform/packages/shared/kbn-management`.\r\nIn this
scenario, I believe the simplification is worth the trade off.\r\n\r\nCC
@elastic/kibana-management WDYT?\r\n\r\nCo-authored-by: Matthew Kime
<matt@mattki.me>","sha":"b2b3fa9a84034bf6a49a38ea3b434245582c7909"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
gsoldevila added a commit that referenced this pull request Feb 19, 2025
#211690)

# Backport

This will backport the following commits from `main` to `8.x`:
- [SKA: Unify &#x60;kbn-management&#x60; folders + storybook config
(#211564)](#211564)

<!--- Backport version: 9.6.4 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Gerard
Soldevila","email":"gerard.soldevila@elastic.co"},"sourceCommit":{"committedDate":"2025-02-19T08:10:22Z","message":"SKA:
Unify `kbn-management` folders + storybook config (#211564)\n\n##
Summary\r\n\r\nAs part of the SKA, some groups of modules have been
broken-down and\r\nrelocated in different folders, negatively impacting
DX. This is the\r\ncase for `kbn-management` modules, that are spread
across:\r\n```\r\n- packages/kbn-management (storybook config)\r\n-
src/platform/packages/private/kbn-management\r\n-
src/platform/packages/shared/kbn-management\r\n```\r\n\r\nThe goal of
this PR is to unify them back
under\r\n`src/platform/packages/shared/kbn-management`.\r\nIn this
scenario, I believe the simplification is worth the trade off.\r\n\r\nCC
@elastic/kibana-management WDYT?\r\n\r\nCo-authored-by: Matthew Kime
<matt@mattki.me>","sha":"b2b3fa9a84034bf6a49a38ea3b434245582c7909","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Kibana
Management","release_note:skip","v9.0.0","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"SKA:
Unify `kbn-management` folders + storybook
config","number":211564,"url":"https://github.com/elastic/kibana/pull/211564","mergeCommit":{"message":"SKA:
Unify `kbn-management` folders + storybook config (#211564)\n\n##
Summary\r\n\r\nAs part of the SKA, some groups of modules have been
broken-down and\r\nrelocated in different folders, negatively impacting
DX. This is the\r\ncase for `kbn-management` modules, that are spread
across:\r\n```\r\n- packages/kbn-management (storybook config)\r\n-
src/platform/packages/private/kbn-management\r\n-
src/platform/packages/shared/kbn-management\r\n```\r\n\r\nThe goal of
this PR is to unify them back
under\r\n`src/platform/packages/shared/kbn-management`.\r\nIn this
scenario, I believe the simplification is worth the trade off.\r\n\r\nCC
@elastic/kibana-management WDYT?\r\n\r\nCo-authored-by: Matthew Kime
<matt@mattki.me>","sha":"b2b3fa9a84034bf6a49a38ea3b434245582c7909"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/211564","number":211564,"mergeCommit":{"message":"SKA:
Unify `kbn-management` folders + storybook config (#211564)\n\n##
Summary\r\n\r\nAs part of the SKA, some groups of modules have been
broken-down and\r\nrelocated in different folders, negatively impacting
DX. This is the\r\ncase for `kbn-management` modules, that are spread
across:\r\n```\r\n- packages/kbn-management (storybook config)\r\n-
src/platform/packages/private/kbn-management\r\n-
src/platform/packages/shared/kbn-management\r\n```\r\n\r\nThe goal of
this PR is to unify them back
under\r\n`src/platform/packages/shared/kbn-management`.\r\nIn this
scenario, I believe the simplification is worth the trade off.\r\n\r\nCC
@elastic/kibana-management WDYT?\r\n\r\nCo-authored-by: Matthew Kime
<matt@mattki.me>","sha":"b2b3fa9a84034bf6a49a38ea3b434245582c7909"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
gsoldevila added a commit that referenced this pull request Feb 19, 2025
… (#211691)

# Backport

This will backport the following commits from `main` to `8.18`:
- [SKA: Unify &#x60;kbn-management&#x60; folders + storybook config
(#211564)](#211564)

<!--- Backport version: 9.6.4 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Gerard
Soldevila","email":"gerard.soldevila@elastic.co"},"sourceCommit":{"committedDate":"2025-02-19T08:10:22Z","message":"SKA:
Unify `kbn-management` folders + storybook config (#211564)\n\n##
Summary\r\n\r\nAs part of the SKA, some groups of modules have been
broken-down and\r\nrelocated in different folders, negatively impacting
DX. This is the\r\ncase for `kbn-management` modules, that are spread
across:\r\n```\r\n- packages/kbn-management (storybook config)\r\n-
src/platform/packages/private/kbn-management\r\n-
src/platform/packages/shared/kbn-management\r\n```\r\n\r\nThe goal of
this PR is to unify them back
under\r\n`src/platform/packages/shared/kbn-management`.\r\nIn this
scenario, I believe the simplification is worth the trade off.\r\n\r\nCC
@elastic/kibana-management WDYT?\r\n\r\nCo-authored-by: Matthew Kime
<matt@mattki.me>","sha":"b2b3fa9a84034bf6a49a38ea3b434245582c7909","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Kibana
Management","release_note:skip","v9.0.0","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"SKA:
Unify `kbn-management` folders + storybook
config","number":211564,"url":"https://github.com/elastic/kibana/pull/211564","mergeCommit":{"message":"SKA:
Unify `kbn-management` folders + storybook config (#211564)\n\n##
Summary\r\n\r\nAs part of the SKA, some groups of modules have been
broken-down and\r\nrelocated in different folders, negatively impacting
DX. This is the\r\ncase for `kbn-management` modules, that are spread
across:\r\n```\r\n- packages/kbn-management (storybook config)\r\n-
src/platform/packages/private/kbn-management\r\n-
src/platform/packages/shared/kbn-management\r\n```\r\n\r\nThe goal of
this PR is to unify them back
under\r\n`src/platform/packages/shared/kbn-management`.\r\nIn this
scenario, I believe the simplification is worth the trade off.\r\n\r\nCC
@elastic/kibana-management WDYT?\r\n\r\nCo-authored-by: Matthew Kime
<matt@mattki.me>","sha":"b2b3fa9a84034bf6a49a38ea3b434245582c7909"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/211564","number":211564,"mergeCommit":{"message":"SKA:
Unify `kbn-management` folders + storybook config (#211564)\n\n##
Summary\r\n\r\nAs part of the SKA, some groups of modules have been
broken-down and\r\nrelocated in different folders, negatively impacting
DX. This is the\r\ncase for `kbn-management` modules, that are spread
across:\r\n```\r\n- packages/kbn-management (storybook config)\r\n-
src/platform/packages/private/kbn-management\r\n-
src/platform/packages/shared/kbn-management\r\n```\r\n\r\nThe goal of
this PR is to unify them back
under\r\n`src/platform/packages/shared/kbn-management`.\r\nIn this
scenario, I believe the simplification is worth the trade off.\r\n\r\nCC
@elastic/kibana-management WDYT?\r\n\r\nCo-authored-by: Matthew Kime
<matt@mattki.me>","sha":"b2b3fa9a84034bf6a49a38ea3b434245582c7909"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.18.0 v8.19.0 v9.0.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants