Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unskip Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/maps/group4/file_upload/shapefile·js #211310

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Feb 14, 2025

Closes #209228 and #209848

Maps only fetch data for visible area. A smaller screen could result in less documents getting returned. This PR resolves the flakyness by setting the screen size before running to ensure the correct screen area and consistent results.

Flaky test runner https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7887

…nctional/apps/maps/group4/file_upload/shapefile·js
@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7887

[✅] x-pack/test/functional/apps/maps/group4/config.ts: 25/25 tests passed.

see run history

@nreese nreese marked this pull request as ready for review February 14, 2025 19:19
@nreese nreese requested a review from a team as a code owner February 14, 2025 19:19
@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v9.0.0 backport:version Backport to applied version labels v9.1.0 labels Feb 14, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese nreese added release_note:skip Skip the PR/issue when compiling release notes test labels Feb 14, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 14, 2025

💔 Build Failed

Failed CI Steps

History

Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTR Results and changes LGTM!

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7888

[✅] x-pack/test/functional/apps/maps/group4/config.ts: 25/25 tests passed.

see run history

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas test v9.0.0 v9.1.0
Projects
None yet
4 participants